[wpt-sync] Sync PR 24017 - Pass the PreferredColorScheme to SVGImage
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24017 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24017
Details from upstream follow.
Alison Maher <almaher@microsoft.com> wrote:
Pass the PreferredColorScheme to SVGImage
As a result of http://crrev.com/c/2079192, the PreferredColorScheme
is stored and accessed through WebSettings instead of WebThemeEngine.
With this change, SVGImage no longer can retrieve the correct
PreferredColorScheme needed to respond to the prefers-color-scheme
media query as it had before.To fix this, pass the PreferredColorScheme from Settings to
SVGImage via SVGImage::DataChange().Bug: 1090464,1090660
Change-Id: I0aacd08930fad21f55c9dfa8dd1b8f747912237dReviewed-on: https://chromium-review.googlesource.com/2230909
WPT-Export-Revision: 7792bf966be4e9f06ce700737af06ec93fd08dfa
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf0c1a9b0328d56a3f75e7b43453612466c5c55d
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL : 1
ERROR: 1
Chrome
FAIL : 1
Safari
FAIL : 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/css/css-color-adjust/rendering/dark-color-scheme/svg-as-image.html: ERROR [GitHub
], FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1c18500c68d [wpt PR 24017] - Pass the PreferredColorScheme to SVGImage, a=testonly https://hg.mozilla.org/integration/autoland/rev/318f8f1d6831 [wpt PR 24017] - Update wpt metadata, a=testonly
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e1c18500c68d
https://hg.mozilla.org/mozilla-central/rev/318f8f1d6831
Description
•