1643850 - Do not search for `www.<something>` strings

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[:Gijs (he/him)]

It's a little surprising that for incomplete domains that are clearly domains because they start with www. (which, without much evidence, I hypothesize people still use frequently...), we now search. It would seem more natural to complete with .com or similar, rather than potentially expose history to the search engine.

Comment 1

[Marco Bonardo [:mak]]

(In reply to :Gijs (he/him) from comment #0)

It's a little surprising that for incomplete domains that are clearly domains because they start with www. (which, without much evidence, I hypothesize people still use frequently...), we now search. It would seem more natural to complete with .com or similar, rather than potentially expose history to the search engine.

If the domain is known we autofill, but if it's not known it's not trivial. I think it would be fine to add the "starts-with-www." heuristic and refuse to search, but also completing may not be trivial or expected (completing www.site to www.site.com may be wrong if site is an intranet host). I'd rather just visit and show a not found error page.

Comment 2

[Marco Bonardo [:mak]]

Just to clarify, I think this can be fixed in uriFixup, if something starts with www. it should not do a keywordLooup.

Comment 3

[Daisuke Akatsuka (:daisuke)]

I thought the same thing!
Thank you very much for your advice!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1643850: Handle 'www.<something>' as a URI.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef9cec5140c9
Handle 'www.<something>' as a URI. r=mak

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ef9cec5140c9