[wpt-sync] Sync PR 24022 - [css-grid] Considering baseline shim when computing max-content size
Categories
(Core :: Layout: Grid, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24022 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24022
Details from upstream follow.
Javier Fernandez <jfernandez@igalia.com> wrote:
[css-grid] Considering baseline shim when computing max-content size
When computing the MaxContentForChild size for the tracks by the
IndefiniteStrategy we were not considering the baseline shim, since we
assumed it was enough to do it for the MinContentSize.However, there are possible definitions of the grid track that cause
the MinContentForChild function to not be called, leading to an
incorrect intrinsic size for the grid.Bug: 1091944
Change-Id: I91a35852dd044ded0fc14f03e97d3e140d80ba12
Reviewed-on: https://chromium-review.googlesource.com/2233239
WPT-Export-Revision: eca1c41657e279a6faf2e49e12ecfd8fc7ce6d82
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=42866c2dd084959af8e378a93514d170e53bd4c9
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 6 tests and 24 subtests
Status Summary
Firefox
OK : 6
PASS: 192
Chrome
OK : 6
PASS: 160
FAIL: 32
Safari
OK : 6
PASS: 192
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a16cd733e4a0 [wpt PR 24022] - [css-grid] Considering baseline shim when computing max-content size, a=testonly
Comment 4•4 years ago
|
||
bugherder |
Description
•