1644083 - Open extension popup windows in a lightweight window, not messenger.xhtml

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Currently if an extension calls browser.windows.create({ url: … , type: "popup" }), a new instance of messenger.xhtml opens, the URL is loaded in a new tab, and everything else is hidden. While this works, it's a real mess and should be avoided.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1644083-popup-window-1.diff

This copies browserRequest.xhtml which has most of what we want, and modifies it to load WebExtension pages or any old URL, which is needed for bug 1644000. It's not complete (there's no context menu yet, for example) but is better than what we had, plus it allows the browser.identity API to be enabled.

Comment 2

[Geoff Lankow (:darktrojan)]

Hmm, I think I may change the names to extensionPopupWindow.js/xhtml. It could be easily confused with the other (in-window) type of popup.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9154876 [details] [diff] [review]
1644083-popup-window-1.diff

Review of attachment 9154876 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ae200f28e7b
Open extension popup windows in a lightweight window, not messenger.xhtml. r=mkmelin

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9154876 [details] [diff] [review]
1644083-popup-window-1.diff

Kind of needed for WX APIs

Comment 6

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/e81c949b4a22