Open extension popup windows in a lightweight window, not messenger.xhtml
Categories
(Thunderbird :: Add-Ons: Extensions API, enhancement)
Tracking
(thunderbird78+ fixed)
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
9.72 KB,
patch
|
mkmelin
:
review+
mkmelin
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Currently if an extension calls browser.windows.create({ url: … , type: "popup" })
, a new instance of messenger.xhtml opens, the URL is loaded in a new tab, and everything else is hidden. While this works, it's a real mess and should be avoided.
Assignee | ||
Comment 1•4 years ago
|
||
This copies browserRequest.xhtml which has most of what we want, and modifies it to load WebExtension pages or any old URL, which is needed for bug 1644000. It's not complete (there's no context menu yet, for example) but is better than what we had, plus it allows the browser.identity API to be enabled.
Assignee | ||
Comment 2•4 years ago
|
||
Hmm, I think I may change the names to extensionPopupWindow.js/xhtml. It could be easily confused with the other (in-window) type of popup.
Comment 3•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/1ae200f28e7b
Open extension popup windows in a lightweight window, not messenger.xhtml. r=mkmelin
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
bugherder uplift |
Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/e81c949b4a22
Assignee | ||
Updated•4 years ago
|
Description
•