Closed Bug 1644205 Opened 5 years ago Closed 5 years ago

Add Pref Value for more en-US locales

Categories

(Firefox :: New Tab Page, task, P1)

79 Branch
Desktop
All
task

Tracking

()

VERIFIED FIXED
Firefox 79
Tracking Status
firefox78 - verified
firefox79 --- verified

People

(Reporter: digitalnewslab, Assigned: thecount)

Details

Attachments

(1 file)

Add Pref values for more en-US Locales.

Severity: S1 → S3
Assignee: nobody → sdowne
Component: Migration → New Tab Page
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/3752c531f917 Enable Ireland as possible future region for pocket stories r=gvn

[Tracking Requested - why for this release]: This is just a configuration change, shouldn't change anything until browser.newtabpage.activity-stream.discoverystream.region-stories-config pref is changed to include IE in the csv.

Comment on attachment 9155398 [details]
Bug 1644205 - Enable Ireland as possible future region for pocket stories

Beta/Release Uplift Approval Request

  • User impact if declined: Users in Ireland would be delayed in their rollout of Pocket content in newtab.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Just general regression testing making sure newtab still displays in US and IE regions.

With a new profile

  1. Flip browser.search.region to IE
  2. Restart.

Should not see pocket stories.

  1. Flip back to US
  2. restart

Should see pocket stories again.

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's just a 1 line config change for functionality we're already using in other regions.
  • String changes made/needed: none
Attachment #9155398 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
QA Whiteboard: [qa-triaged]

Comment on attachment 9155398 [details]
Bug 1644205 - Enable Ireland as possible future region for pocket stories

approved for 78.0b6

Attachment #9155398 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified that the "Recommended by Pocket" section is not displayed when the browser.search.region pref is set to IE and it is displayed after the browser.search.region pref is set to US.

Verified using the latest Firefox Beta (78.0b9 Build ID - 20200619002543) and the latest Firefox Nightly (79.0a1 Build ID - 20200621093846) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: