1644251 - 78 beta - L10n repacks fail

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

This is happening on all platforms for Thunderbird 78.0beta1.

RuntimeError: File "brand.dtd" not found in /builds/worker/workspace/obj-build/comm/mail/locales/merge-dir/bg/comm/mail/branding/thunderbird

From Pike:
rjl: you need a hack like https://searchfox.org/comm-central/source/mail/locales/Makefile.in#5-6 in mail/branding/thunderbird/locales

Comment 1

[Rob Lemley [:rjl]]

Attachment: bug1644251.patch

[Approval Request Comment]
Needed to move 78 beta forward.

Comment 2

[Geoff Lankow (:darktrojan)]

I don't think you want the /locales on the end, since the files are at mail/branding/thunderbird.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5f88da0be7ee
Set paths for L10n repacks when using official branding. r=mkmelin

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/63f5cfcdb5c6

Comment 5

[Rob Lemley [:rjl]]

(In reply to Geoff Lankow (:darktrojan) from comment #2)

I don't think you want the /locales on the end, since the files are at mail/branding/thunderbird.

This file gets used in the context of L10n repack, so the paths are different.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9155102 [details] [diff] [review]
bug1644251.patch

Approved post-landing. Thanks