Closed Bug 1644332 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 24052 - Revert "Reland "Disable tests for landing a WebRTC name change""

Categories

(Core :: WebRTC, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24052 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24052
Details from upstream follow.

Harald Alvestrand <hta@chromium.org> wrote:

Revert "Reland "Disable tests for landing a WebRTC name change""

This reverts commit 09943e0534d00ce589ff8de249c9f074b978e387.

Reason for revert: Accounted for the differences.

Original change's description:

Reland "Disable tests for landing a WebRTC name change"

This reverts commit 45e0194e5d28fe640ae58b467062c0e2e0c92e35.

Reason for revert: Breaks tests:
virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-getStats.https.html
external/wpt/webrtc/RTCPeerConnection-getStats.https.html


First build with broken tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/25785

Sample of the diff:
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=16ebfc26e79fdeaf98748ad686bbaa6208658dee&as=RTCPeerConnection-getStats.https-diff.txt

Original change's description:

Revert "Disable tests for landing a WebRTC name change"
and rebase changed tests.

This reverts commit 328f27b7be6a3637b9e50b9a2a88e311d575ec09.

Reason for revert: Change has now landed

Original change's description:

Disable tests for landing a WebRTC name change

Bug: webrtc:8787
Change-Id: I5a166726bf236e088426734456f2d503e3c6875e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232554
Reviewed-by: Guido Urdaneta \<guidou@chromium.org>
Commit-Queue: Harald Alvestrand \<hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775594}

TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:8787
Change-Id: Ic074a1b1231f90363bf6af7a581c8044bef947c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235041
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Reviewed-by: Guido Urdaneta \<guidou@chromium.org>
Commit-Queue: Harald Alvestrand \<hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776151}

TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org

Not skipping CQ checks because this is a reland.

Bug: webrtc:8787
Change-Id: I17941d275de9e918529944428f69fdec511684e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236471
Reviewed-by: Dmitry Titov \<dimich@chromium.org>
Commit-Queue: Dmitry Titov \<dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776287}

TBR=hta@chromium.org,dimich@chromium.org,hbos@chromium.org,guidou@chromium.org

Change-Id: Icba4b6b15f55d22df2c8b73fbb66cc5bf2b75bd5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8787

Reviewed-on: https://chromium-review.googlesource.com/2236399
WPT-Export-Revision: 18c0eab7a2509b40077e7d4f09487e381d37676d

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 2 subtests

Status Summary

Firefox

OK : 8
PASS : 48
FAIL : 75
TIMEOUT: 2
NOTRUN : 5

Chrome

OK : 9
PASS : 91
FAIL : 38

Safari

OK : 7
PASS : 14
FAIL : 33
TIMEOUT: 4
NOTRUN : 80

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webrtc/RTCPeerConnection-getStats.https.html
getStats() with no argument should return stats report containing peer-connection stats on an empty PC: FAIL
/webrtc/RTCPeerConnection-track-stats.https.html: TIMEOUT
RTCRtpSender.getStats() contains only outbound-rtp and related stats: TIMEOUT
RTCRtpReceiver.getStats() contains only inbound-rtp and related stats: NOTRUN
O/A exchange yields inbound RTP stream stats for receiving track: FAIL
O/A exchange yields outbound RTP stream stats for sending track: FAIL
addTrack() without setLocalDescription() yields track stats: FAIL
RTCPeerConnection.getStats(receivingTrack) is the same as RTCRtpReceiver.getStats(): NOTRUN
RTCPeerConnection.getStats(sendingTrack) is the same as RTCRtpSender.getStats(): NOTRUN
addTrack() with setLocalDescription() yields track stats: FAIL

New Tests That Don't Pass

/webrtc/RTCPeerConnection-mandatory-getStats.https.html
RTCRtpStreamStats's transportId: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCPeerConnectionStats's dataChannelsOpened: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCCodecStats's payloadType: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCCodecStats's clockRate: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCTransportStats's rtcpTransportStatsId: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCMediaHandlerStats's trackIdentifier: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCOutboundRtpStreamStats's senderId: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCCodecStats's sdpFmtpLine: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCAudioHandlerStats's audioLevel: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCMediaHandlerStats's ended: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCMediaHandlerStats's remoteSource: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCTransportStats's remoteCertificateId: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCTransportStats's selectedCandidatePairId: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCVideoSenderStats's framesSent: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCOutboundRtpStreamStats's trackId: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCMediaStreamStats's streamIdentifer: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCVideoReceiverStats's framesDecoded: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCCertificateStats's fingerprintAlgorithm: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCIceCandidateStats's url: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCVideoReceiverStats's framesReceived: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCTransportStats's bytesSent: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCCertificateStats's base64Certificate: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCMediaStreamStats's trackIds: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCVideoReceiverStats's partialFramesLost: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCVideoHandlerStats's frameHeight: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCCodecStats's codecType: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCIceCandidatePairStats's totalRoundTripTime: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCCertificateStats's fingerprint: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCTransportStats's localCertificateId: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCRtpStreamStats's codecId: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCPeerConnectionStats's dataChannelsClosed: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCIceCandidatePairStats's currentRoundTripTime: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCReceivedRtpStreamStats's packetsDiscarded: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCVideoHandlerStats's framesPerSecond: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCInboundRtpStreamStats's trackId: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCInboundRtpStreamStats's receiverId: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCVideoHandlerStats's frameWidth: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCCodecStats's channels: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCCertificateStats's issuerCertificateId: FAIL (Chrome: FAIL, Safari: NOTRUN)
RTCTransportStats's bytesReceived: FAIL (Chrome: PASS, Safari: NOTRUN)
RTCVideoReceiverStats's framesDropped: FAIL (Chrome: FAIL, Safari: NOTRUN)
/webrtc/protocol/crypto-suite.https.html
srtpCipher is acceptable on video-only: FAIL (Chrome: PASS, Safari: FAIL)
srtpCipher is acceptable on data-only: FAIL (Chrome: PASS, Safari: FAIL)
tlsGroup is acceptable on video-only: FAIL (Chrome: FAIL, Safari: FAIL)
tlsGroup is acceptable on data-only: FAIL (Chrome: FAIL, Safari: FAIL)
dtlsCipher is acceptable on video-only: FAIL (Chrome: PASS, Safari: FAIL)
dtlsCipher is acceptable on data-only: FAIL (Chrome: PASS, Safari: FAIL)
tlsVersion is acceptable on video-only: FAIL (Chrome: PASS, Safari: FAIL)
tlsVersion is acceptable on data-only: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc/RTCRtpReceiver-getStats.https.html
receiver.getStats() via addTrack should return stats report containing inbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)
receiver.getStats() via addTransceiver should return stats report containing inbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)
/webrtc/RTCPeerConnection-getStats.https.html
getStats() with connected peer connections having tracks and data channel should return all mandatory to implement stats: FAIL (Chrome: FAIL, Safari: FAIL)
getStats() on track associated with RtpReceiver should return stats report containing inbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)
getStats() with no argument should return stats for no-stream tracks: FAIL (Chrome: FAIL, Safari: FAIL)
getStats() on track associated with RtpSender should return stats report containing outbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)
getStats() with no argument should return stats report containing peer-connection stats on an empty PC: FAIL (Chrome: PASS, Safari: PASS)
/webrtc/legacy/RTCPeerConnection-addStream.https.html
Legacy addStream(): Media stream stats references track stats: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc/RTCPeerConnection-track-stats.https.html: TIMEOUT (Chrome: OK, Safari: OK)
replaceTrack() before offer: new track attachment stats present: FAIL (Chrome: PASS, Safari: FAIL)
replaceTrack() after offer, before answer: new track attachment stats present: FAIL (Chrome: PASS, Safari: FAIL)
addTrack() with setLocalDescription() yields media stream stats: FAIL (Chrome: PASS, Safari: FAIL)
RTCRtpSender.getStats() contains only outbound-rtp and related stats: TIMEOUT (Chrome: PASS, Safari: PASS)
RTCRtpReceiver.getStats() contains only inbound-rtp and related stats: NOTRUN (Chrome: PASS, Safari: PASS)
O/A exchange yields inbound RTP stream stats for receiving track: FAIL (Chrome: PASS, Safari: PASS)
replaceTrack(): original track attachment stats present after replacing: FAIL (Chrome: FAIL, Safari: FAIL)
Media stream stats references track stats: FAIL (Chrome: PASS, Safari: FAIL)
O/A exchange yields outbound RTP stream stats for sending track: FAIL (Chrome: PASS, Safari: PASS)
addTrack(): Media stream stats references track stats: FAIL (Chrome: PASS, Safari: FAIL)
addTrack() without setLocalDescription() yields track stats: FAIL (Chrome: PASS, Safari: PASS)
RTCPeerConnection.getStats(track) throws InvalidAccessError when there are zero senders or receivers for the track: NOTRUN (Chrome: PASS, Safari: FAIL)
RTCPeerConnection.getStats(track) throws InvalidAccessError when there are multiple senders for the track: NOTRUN (Chrome: PASS, Safari: FAIL)
replaceTrack() after answer: new track attachment stats present: FAIL (Chrome: PASS, Safari: FAIL)
RTCPeerConnection.getStats(receivingTrack) is the same as RTCRtpReceiver.getStats(): NOTRUN (Chrome: PASS, Safari: PASS)
RTCPeerConnection.getStats(sendingTrack) is the same as RTCRtpSender.getStats(): NOTRUN (Chrome: PASS, Safari: PASS)
addTrack() with setLocalDescription() yields track stats: FAIL (Chrome: PASS, Safari: PASS)
addTrack() without setLocalDescription() yields media stream stats: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc-extensions/RTCRtpSynchronizationSource-captureTimestamp.html
Audio and video RTCRtpSynchronizationSource.captureTimestamp are comparable: FAIL (Chrome: PASS, Safari: NOTRUN)
[audio] getSynchronizationSources() should contain captureTimestamp if absolute capture time RTP header extension is negotiated: FAIL (Chrome: PASS, Safari: NOTRUN)
[video] getSynchronizationSources() should contain captureTimestamp if absolute capture time RTP header extension is negotiated: FAIL (Chrome: PASS, Safari: NOTRUN)
/webrtc-stats/getStats-remote-candidate-address.html
Do not expose in stats remote addresses that are not known to be already exposed to JS: FAIL (Chrome: FAIL, Safari: FAIL)
/webrtc/RTCRtpSender-getStats.https.html
sender.getStats() via addTrack should return stats report containing outbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)
sender.getStats() via addTransceiver should return stats report containing outbound-rtp stats: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae468e6a60d0
[wpt PR 24052] - Revert "Reland "Disable tests for landing a WebRTC name change"", a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.