Closed Bug 1644514 Opened 4 years ago Closed 2 years ago

Incredible bad rendering performance on digitalocean.com hero due to Webrender display list jank

Categories

(Core :: Graphics: WebRender, defect)

79 Branch
Desktop
Windows 10
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox79 --- affected

People

(Reporter: jens1o, Unassigned)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

STR:
Navigate to https://digitalocean.com.

Observe that the hero animation with the fishes feel incredibly janky, impacting site scroll performance.

Profiles:
https://share.firefox.dev/3dPY7AF
https://share.firefox.dev/3gPGQtj (older one, but it seems it's somehow better at finding out what's happening)

Please find the attached about:support output (used in the first profile in the list).

I tested the same website with Chromium, and there it is not janky at all, but a smooth animation.

Component: Graphics → Graphics: WebRender
Flags: needinfo?(aosmond)

I'm not sure if there is a deeper question here, but that is the size that is requested. It is a very large SVG, and we scale it up a fair bit to fit the whole background. This makes sense no?

I did realize from this code hunt that we don't apply the image.cache.max-rasterized-svg-threshold-kb pref to surfaces that bypass the cache (e.g. due to having an animation). I wrote a patch to take that into account, however 5688x1600 = 34.7 MB surface, while the threshold defaults to 200 MB, so it wouldn't clamp it anyways.

It draws at the same size in non-WebRender, so it isn't like we are doing something clever....

Flags: needinfo?(aosmond)

In this case maybe we want to be clipping it so that we only draw it as big as needed to fill element that it's the background of.

Severity: -- → S3
Blocks: wr-blob-perf
No longer blocks: wr-perf

The website changed and we have a number of similar svg animation perf bugs on file so I'll close this one.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: