Closed Bug 1644569 Opened 2 years ago Closed 2 years ago

Unused mutable static buffer in Win32 nsFilePicker

Categories

(Core :: Widget: Win32, defect)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The static variable nsFilePicker::mLastUsedDirectory is declared as a char[MAX_PATH + 1] but is then never used. Since it is mutable and static, we end up with this buffer being allocated in every single process.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67567acee3d2
Removed unused nsFilePicker::mLastUsedDirectory; r=mhowell
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.