1644617 - Uplift pdf.js patch that displays fallback bar only when form is clicked

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, task)

Description

[Emma Malysz]

The original github issue is https://github.com/mozilla/pdf.js/issues/11838
The PR associated with that is here: https://github.com/mozilla/pdf.js/commit/891c706aa81d4755b84280a0d1360540153de8f1

We are hoping to uplift this to 78.

Thanks for offering to help out with this, Ryan!

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1644617 - Trigger fallback bar after user clicks in pdf.

Backport of upstream commit https://github.com/mozilla/pdf.js/commit/891c706aa81d4755b84280a0d1360540153de8f1

Comment 2

[Emma Malysz]

Comment on attachment 9155490 [details]
Bug 1644617 - Trigger fallback bar after user clicks in pdf.

Beta/Release Uplift Approval Request

• User impact if declined: Users immediately are shown the fallback error that redirects to Edge. We estimate we send over 1 million users monthly to edge, so if we do not show this fallback bar immediately, we potentially can reduce this number.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: With the patch applied:

1. Build firefox
2. Open http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf
3. Notice fallback bar does not appear.
4. Click in document (or tab in)
5. Notice fallback error message appears.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fallback error message will still be displayed for the first non-form error recorded, so if there is another fallback error, the user will still see the fallback error. This is only meant to help forms that do not have other errors.

There are also no string changes.

• String changes made/needed: N/a

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Fixed for 79+ by way of bug 1644142.

Comment 4

[Alin Ilea, Desktop QA]

Reproduced the initial issue with Beta 78.0b4 (build id: 20200605150717).
Verified - Fixed in latest Nightly build 79.0a1 (build id: 20200610214041) using Windows 10 and Ubuntu 18.04.

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9155490 [details]
Bug 1644617 - Trigger fallback bar after user clicks in pdf.

approved for 78.0b6

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/624a4a0fea7b

Comment 7

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Beta build 78.0b6 (build id: 20200611105443). The fallback error message is displayed just after the user clicks in the document.