Closed Bug 1644636 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 24077 - Extract a list of valid URLs from the resources attribute value

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox79 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24077 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24077
Details from upstream follow.

Hayato Ito <hayato@chromium.org> wrote:

Extract a list of valid URLs from the resources attribute value

We need a list of valid URLs from \<link> element's resources attribute
value so that we can tell whether subresources should be loaded from
the WebBundle or not.

This CL does:

  • Change \<link> element's resources= attribute to DOMTokenList
  • Make HTMLLinkElement have |valid_resource_urls_|, which is a list of
    valid urls and will be used later. |valid_resource_urls_| should be
    updated whenever resources attribute changes.

Note that changing the type of resources attribute to DOMTokenList is not
mandatory here. That's just for web developer ergonomics.

Change-Id: Ic10abab4bf8e07b245fea7e39becc5ab1aa2c82a

Reviewed-on: https://chromium-review.googlesource.com/2237496
WPT-Export-Revision: 18ba3f1392cf5d799e9f0c33499c341d5bfb1f2a

PR 24077 applied with additional changes from upstream: 90379adf70b7c58111ecefb8d6f99667ae297ca6

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 3

Chrome

OK : 1
PASS: 2
FAIL: 3

Safari

OK : 1
PASS: 2
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-bundle/subresource-loading/link-web-bundle.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
resources must be DOMTokenList: FAIL (Chrome: FAIL, Safari: FAIL)
resources must be defined on HTMLLinkElement prototype: FAIL (Chrome: FAIL, Safari: FAIL)
webbundle must be a supported token of a link element's relList: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/web-bundle/subresource-loading/link-web-bundle.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/acb27f9ab6c4 [wpt PR 24077] - Extract a list of valid URLs from the resources attribute value, a=testonly

https://hg.mozilla.org/mozilla-central/rev/acb27f9ab6c4

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.