1644650 - [a11y]After the conversion to an XHTML document, the whole of dev tools must be a role "application" for assistive technologies

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Marco Zehe (:MarcoZ)]

This regressed when DevTools as a whole became based on an XHTML document rather than a XUL document. Screen readers like NVDA would otherwise treat it as a document, which is not appropriate.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1644650 - Make the main developer tools window an application for assistive technologies again,

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f667f941e5b8
Make the main developer tools window an application for assistive technologies again, r=nchevobbe

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f667f941e5b8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Hi Marco, do we want to uplift this to Beta so the next ESR release also contains the fix? Please nominate for approval if so.

Comment 5

[Marco Zehe (:MarcoZ)]

Thanks for the heads-up, Ryan! We definitely want this. :-)

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 9155525 [details]
Bug 1644650 - Make the main developer tools window an application for assistive technologies again,

Beta/Release Uplift Approval Request

• User impact if declined: Screen readers might switch to document browsing mode unexpectedly once the user enters the main developer tools window.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: With the NVDA screen reader on Windows:

1. Run Firefox.
2. Turn on developer tools by pressing F12.
3. Tab to the toolbar, the main toolbox.
   • Expected: NVDA should stay in application mode at all times, not emit a low beep to indicate that it has switched to browse mode.

• List of other uplifts needed: None.
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds a semantic attribute to indicate to assistive technologies that the main window is an application, and the vbox is a grouping.
• String changes made/needed: None.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9155525 [details]
Bug 1644650 - Make the main developer tools window an application for assistive technologies again,

approved for 78.0b6

Comment 8

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue with an old Nightly build 79.0a1 (build id: 20200609092134).
Verified - Fixed in latest Nightly build 79.0a1 (build id: 20200610214041) using NVDA on Windows 10.

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/edf2dbba5c32

Comment 10

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta build 78.0b6 (build id: 20200611104559) using NVDA on Windows 10.