passwords are displayed in NSS command-line tools on OS/2

VERIFIED FIXED in 3.6

Status

NSS
Libraries
P2
normal
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: Julien Pierre, Assigned: Wan-Teh Chang)

Tracking

unspecified
x86
OS/2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
When NSS prompts for the token password, it is echo'ed on OS/2, when it's not
supposed to be.
(Reporter)

Updated

15 years ago
Priority: -- → P2
Target Milestone: --- → 3.6
(Reporter)

Comment 1

15 years ago
Created attachment 96576 [details] [diff] [review]
patch to do hidden input on OS/2, very similar to windows. Checked in

I only put these changes in for the VACPP compiler on OS/2. Presumably EMX
takes care of this in the C library the same way as Unix, so it isn't a problem
there.
(Reporter)

Comment 2

15 years ago
Checking in secpwd.c;
/cvsroot/mozilla/security/nss/cmd/lib/secpwd.c,v  <--  secpwd.c
new revision: 1.11; previous revision: 1.10
done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

15 years ago
Comment on attachment 96576 [details] [diff] [review]
patch to do hidden input on OS/2, very similar to windows. Checked in

>+#ifndef XP_OS2_VACPP
>   if (input != stdin) {
>      return fgets(buf,length,input);
>   }
>+#else
>+  if (!isatty(fileno(input))) {
>+     return fgets(buf,length,input);
>+  }
>+#endif

It would be more readable to use #ifdef XP_OS2_VACPP
and reverse the two blocks, or use #ifdef _WINDOWS.

Comment 4

15 years ago
Julien, please verify. Thanks
(Reporter)

Comment 5

15 years ago
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.