164471 - passwords are displayed in NSS command-line tools on OS/2

Status: VERIFIED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

When NSS prompts for the token password, it is echo'ed on OS/2, when it's not
supposed to be.

Comment 1

[Julien Pierre]

Attachment: patch to do hidden input on OS/2, very similar to windows. Checked in

I only put these changes in for the VACPP compiler on OS/2. Presumably EMX
takes care of this in the C library the same way as Unix, so it isn't a problem
there.

Comment 2

[Julien Pierre]

Checking in secpwd.c;
/cvsroot/mozilla/security/nss/cmd/lib/secpwd.c,v  <--  secpwd.c
new revision: 1.11; previous revision: 1.10
done

Comment 3

[Wan-Teh Chang]

Comment on attachment 96576 [details] [diff] [review]
patch to do hidden input on OS/2, very similar to windows. Checked in

>+#ifndef XP_OS2_VACPP
>   if (input != stdin) {
>      return fgets(buf,length,input);
>   }
>+#else
>+  if (!isatty(fileno(input))) {
>+     return fgets(buf,length,input);
>+  }
>+#endif

It would be more readable to use #ifdef XP_OS2_VACPP
and reverse the two blocks, or use #ifdef _WINDOWS.

Comment 4

[Mike Kaply [:mkaply]]

Julien, please verify. Thanks

Comment 5

[Julien Pierre]

verified