1644745 - June 10 indexer failure

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Updating git
+ pushd /mnt/index-scratch/glean/glean
/mnt/index-scratch/glean/glean ~
+ git pull origin master
fatal: couldn't find remote ref master

Looks like glean renamed their master branch to main? Is there a reason for this?

Comment 1

[Jan-Erik Rediger [:janerik]]

I forgot we had some automatic external tooling that relies on the name.
We decided to renam our default branch, as the wording didn't sit well with anyone anymore.
I'll send a PR to fix this.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: GitHub Pull Request

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Jan-Erik Rediger [:janerik] from comment #1)

We decided to renam our default branch, as the wording didn't sit well with anyone anymore.

Not my call, but breaking standard conventions should generally not be done without a good reason..

Comment 4

[Kartikaya Gupta (email:[e-mail])]

PR merged, retriggered indexer.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)

Not my call, but breaking standard conventions should generally not be done without a good reason..

I believe the good reason and its rationale is captured in this explanation of how to change the branch name:
https://www.hanselman.com/blog/EasilyRenameYourGitDefaultBranchFromMasterToMain.aspx

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Ah, gotcha. I didn't clue in that's what he meant by "wording". Thanks for the explanation!