Closed Bug 1644901 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 24101 - CookieStore: change set() to use CookieInit

Tracking

(firefox79 fixed)

Status:

RESOLVED FIXED

Milestone:

mozilla79

Tracking Flags:

Tracking

Status

firefox79

---

fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 years ago

Sync web-platform-tests PR 24101 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24101
Details from upstream follow.

Ayu Ishii <ayui@chromium.org> wrote:

CookieStore: change set() to use CookieInit

Per TAG review discussion [1], this change updates the set()
method as follows:

Promise\<void> set(USVString name, USVString value);
Promise\<void> set(CookieInit cookieInit);

dictionary CookieInit {
required USVString name;
required USVString value;
USVString? domain = null;
USVString path = "/";
DOMTimeStamp? expires = null;
CookieSameSite sameSite = "strict";
};

[1] https://github.com/WICG/cookie-store/pull/141

Bug: 1087580
Change-Id: Ic22ae0bc7dfc3df71ac849b9acd894316fe01377
Reviewed-on: https://chromium-review.googlesource.com/2220556
WPT-Export-Revision: 1b0350c5576a5bdf9e8f33913dbe7e8ea9e0f618

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fd3c73e1452c4888a2c929ea5791822df895d7e

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 years ago

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 8 subtests

Status Summary

Firefox

OK : 8
FAIL: 100

Chrome

OK : 8
PASS: 100

Safari

OK : 8
FAIL: 100

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookie-store/cookieListItem_attributes.tentative.https.any.serviceworker.html
CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_delete_arguments.tentative.https.any.html
cookieStore.delete with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with missing / at the end of path: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieListItem_attributes.tentative.https.any.html
CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_set_arguments.tentative.https.any.html
cookieStore.set domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set default path is /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with path set to a subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a past timestamp: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set adds / to path that does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with normal name and an '=' in value: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with empty name and an '=' in value: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a future Date: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a past Date: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a future timestamp: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set default domain is null and differs from current hostname: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_special_names.tentative.https.any.serviceworker.html
cookieStore.set with __Host- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set of expired __Host- cookie name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with __Host- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with __Host- prefix and a domain option: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set of expired __Secure- cookie name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with __Host- prefix a path option: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with __Secure- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with __Secure- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_set_arguments.tentative.https.any.serviceworker.html
cookieStore.set domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set default path is /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with path set to a subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a past timestamp: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set adds / to path that does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with normal name and an '=' in value: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with empty name and an '=' in value: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a future Date: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a past Date: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with expires set to a future timestamp: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set default domain is null and differs from current hostname: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_delete_arguments.tentative.https.any.serviceworker.html
cookieStore.delete with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with missing / at the end of path: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_special_names.tentative.https.any.html
cookieStore.set with __Host- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set of expired __Host- cookie name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with __Host- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with __Host- prefix and a domain option: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set of expired __Secure- cookie name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with __Host- prefix a path option: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.set with __Secure- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with __Secure- name on secure origin: FAIL (Chrome: PASS, Safari: FAIL)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1647235

Pulsebot

Comment 3

•

2 years ago

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/899bf600e003
[wpt PR 24101] - CookieStore: change set() to use CookieInit, a=testonly

Dorel Luca [:dluca]

Comment 4

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/899bf600e003

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox79: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla79

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 24101 - CookieStore: change set() to use CookieInit

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox79 fixed)

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Comment 3

Comment 4