Closed Bug 1644940 Opened 4 years ago Closed 4 years ago

Wrap the compositor CALayers inside another CALayer

Categories

(Core :: Widget: Cocoa, task)

All
macOS
task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

At the moment, our compositor thread mutates the sublayers array of mPixelHostingView's backing layer on the compositor thread. This is not so good if Cocoa code on the main thread accesses those sublayers at the same time.

It may be more robust to put another wrapping CALayer in between. Then the view's backing layer only has one sublayer, this new wrapping CALayer. The main thread should hopefully refrain from recursing into its sublayers.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/4473194f0154
Nest the window's CALayers within another level of CALayers. r=spohl
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: