Open Bug 1644991 Opened 5 years ago Updated 5 years ago

Consider eliding more guards in CacheIR-inlined self-hosting intrinsics

Categories

(Core :: JavaScript Engine: JIT, task, P3)

task

Tracking

()

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

For example when we generate the CacheIR, we can assert argument types/count instead of checking for them, similar to what we do in SelfHosting.cpp. We also don't need the emitNativeCalleeGuard guard because we can rely on self-hosted code not calling these intrinsics in weird ways.

We should still document each of these places to prevent copy/paste issues. Also it can be annoying to assert isInt32 because in some cases we might get integers stored as doubles.

Severity: normal → N/A
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.