Closed Bug 1645059 Opened 9 months ago Closed 9 months ago

Enable browser.urlbar.richSuggestions.tail

Categories

(Firefox :: Address Bar, task, P1)

78 Branch
task
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 79
Iteration:
79.2 - June 15 - June 28
Tracking Status
firefox78 + wontfix
firefox79 + verified

People

(Reporter: harry, Assigned: harry)

References

Details

Attachments

(1 file)

All the code for tail suggestions is in 78. The front-end part of the feature is preffed-off, but the backend code has been baking on 78 since before 78 Beta started. Before we pref it on, we need to wait for Google to enable the feature server-side. We're in active discussion with them on this. Thankfully, QA can still test the feature in the meantime: see bug 1626897 comment 9.

As soon as Google enables it server-side, we'd like to quickly lift it to Beta, especially seeing as the majority of the code has baked on 78 for some time.

Component: Search → Address Bar

[Tracking Requested - why for this release]:

This feature has two major components: a change to our backend handling of search suggestions, and a frontend part. The backend handling has been enabled on 78 for several weeks. The frontend part is in 78 and hasn't required changes, but is preffed off while we wait for Google to turn this feature on server-side. Once Google turns on the server-side component, all that remains is for us to pref it on the frontend part.

Assuming Google can get the feature turned on soon, I'm hoping to request a late-ish uplift of this feature. Google's server-side change will change the composition of search suggestions beyond just adding tail suggestions and we should have the front-end ready to support that. If an uplift isn't possible, or Google is late in delivery, then we'll have to go back to Google and ask them to change the server-side component again to only support 79+.

78 goes to RC next week. What sort of QA testing has this gotten?

Flags: needinfo?(htwyford)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)

78 goes to RC next week. What sort of QA testing has this gotten?

Not enough, it seems. The qe-verify flag on bug 1626897 has been sitting at ? for a while - I just changed it to + a couple hours ago.
It seems like Google also isn't quite ready for testing this feature just yet - even though it's a feature that will only be triggered for VERY long search strings - so let's hold off with enabling this on 78.
I discussed this with Harry and reached this conclusion.

We'd like to accommodate Google and do an experiment on 78 release, when and if that's possible at that time.

Flags: needinfo?(htwyford)
Severity: -- → S3
Type: enhancement → task
Priority: -- → P1
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2070942eb750
Enable browser.urlbar.richSuggestions.tail. r=mak
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

I can confirm this fix. I verified using Fx 79.0a1(2020-06-25), on Windows 10 x64 and macOS 10.13.

Status: RESOLVED → VERIFIED
Blocks: 1653085
You need to log in before you can comment on or make changes to this bug.