Closed Bug 1645066 Opened 3 months ago Closed 3 months ago

Perma [tier2] tools/lint/test/test_clippy.py::test_basic TEST-UNEXPECTED-FAIL

Categories

(Firefox Build System :: Lint and Formatting, defect, P5)

defect

Tracking

(firefox78 fixed, firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Sylvestre)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: ccoroiu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=305948114&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QUrClQMZRoO9cX5rRBMaHQ/runs/0/artifacts/public/logs/live_backing.log


task 2020-06-11T14:42:05.729Z] 0:28.61 /builds/worker/checkouts/gecko/tools/lint/test/test_clang_format.py
[task 2020-06-11T14:42:05.730Z] 0:28.61 ============================= test session starts ==============================
[task 2020-06-11T14:42:05.731Z] 0:28.61 platform linux -- Python 3.6.9, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/gecko-QUm8IANb-3/bin/python
[task 2020-06-11T14:42:05.731Z] 0:28.61 rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2020-06-11T14:42:05.731Z] 0:28.61 collecting ... collected 3 items
[task 2020-06-11T14:42:05.732Z] 0:28.61
[task 2020-06-11T14:42:05.732Z] 0:28.61 tools/lint/test/test_clang_format.py::test_good PASSED
[task 2020-06-11T14:42:05.732Z] 0:28.61 tools/lint/test/test_clang_format.py::test_basic PASSED
[task 2020-06-11T14:42:05.732Z] 0:28.61 tools/lint/test/test_clang_format.py::test_dir PASSED
[task 2020-06-11T14:42:05.733Z] 0:28.61
[task 2020-06-11T14:42:05.733Z] 0:28.61 =========================== 3 passed in 0.34 seconds ===========================
[task 2020-06-11T14:42:07.914Z] 0:30.80 /builds/worker/checkouts/gecko/tools/lint/test/test_clippy.py
[task 2020-06-11T14:42:07.915Z] 0:30.80 ============================= test session starts ==============================
[task 2020-06-11T14:42:07.915Z] 0:30.80 platform linux -- Python 3.6.9, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/gecko-QUm8IANb-3/bin/python
[task 2020-06-11T14:42:07.915Z] 0:30.80 rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2020-06-11T14:42:07.915Z] 0:30.80 collecting ... collected 5 items
[task 2020-06-11T14:42:07.915Z] 0:30.80
[task 2020-06-11T14:42:07.915Z] 0:30.80 tools/lint/test/test_clippy.py::test_basic TEST-UNEXPECTED-FAIL
[task 2020-06-11T14:42:07.915Z] 0:30.80 tools/lint/test/test_clippy.py::test_error PASSED
[task 2020-06-11T14:42:07.915Z] 0:30.80 tools/lint/test/test_clippy.py::test_file_and_path_provided TEST-UNEXPECTED-FAIL
[task 2020-06-11T14:42:07.915Z] 0:30.80 tools/lint/test/test_clippy.py::test_file_provided TEST-UNEXPECTED-FAIL
[task 2020-06-11T14:42:07.915Z] 0:30.80 tools/lint/test/test_clippy.py::test_cleanup PASSED
[task 2020-06-11T14:42:07.915Z] 0:30.80
[task 2020-06-11T14:42:07.922Z] 0:30.80 =================================== FAILURES ===================================
[task 2020-06-11T14:42:07.922Z] 0:30.80 __________________________________ test_basic __________________________________
[task 2020-06-11T14:42:07.922Z] 0:30.80
[task 2020-06-11T14:42:07.922Z] 0:30.80 lint = <function lint.<locals>.wrapper at 0x7f32efa1af28>
[task 2020-06-11T14:42:07.924Z] 0:30.80 config = {'description': 'Lint rust', 'exclude': ['Cargo.toml', 'gfx/wr/', 'gfx/wr/webrender/', 'gfx/wr/examples/', 'gfx/wr/web...', 'gfx/webrender_bindings/', 'gfx/wr/direct-composition/', 'gfx/wr/example-compositor/compositor-windows/', ...], ...}
[task 2020-06-11T14:42:07.924Z] 0:30.80 paths = <function paths.<locals>._inner at 0x7f32ecadbf28>
[task 2020-06-11T14:42:07.924Z] 0:30.80
[task 2020-06-11T14:42:07.924Z] 0:30.80 def test_basic(lint, config, paths):
[task 2020-06-11T14:42:07.924Z] 0:30.80 results = lint(paths("test1/"))
[task 2020-06-11T14:42:07.924Z] 0:30.80 print(results)
[task 2020-06-11T14:42:07.924Z] 0:30.80 assert len(results) > 7
[task 2020-06-11T14:42:07.924Z] 0:30.80
[task 2020-06-11T14:42:07.924Z] 0:30.80 assert "is never read" in results[0].message or 'but never used' in results[0].message
[task 2020-06-11T14:42:07.924Z] 0:30.80 assert results[0].level == "warning"
[task 2020-06-11T14:42:07.924Z] 0:30.80 assert results[0].lineno == 7
[task 2020-06-11T14:42:07.924Z] 0:30.80 > assert results[0].column == 13
[task 2020-06-11T14:42:07.924Z] 0:30.80 E assert 9 == 13
[task 2020-06-11T14:42:07.924Z] 0:30.80 E + where 9 = Issue({\n "linter": "clippy",\n "path": "/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad.rs",\n ... "level": "warning",\n "rule": "unused_assignments",\n "lineoffset": 0,\n "diff": null,\n "relpath": "test1/bad.rs"\n}).column
[task 2020-06-11T14:42:07.924Z] 0:30.80
[task 2020-06-11T14:42:07.924Z] 0:30.80 tools/lint/test/test_clippy.py:15: AssertionError

Summary: Perma 0:30.80 tools/lint/test/test_clippy.py::test_basic TEST-UNEXPECTED-FAIL → Perma [tier2] tools/lint/test/test_clippy.py::test_basic TEST-UNEXPECTED-FAIL
Assignee: nobody → sledru
Status: NEW → ASSIGNED
Regressed by: 1644809

Because of the recent changes and update of the docker image, we moved from a version of clippy from march to "clippy 0.0.212 (d4092ac 2020-05-11)"

No longer regressed by: 1644809
See Also: → 1644809
Depends on: 1645829
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97fab3ff3e3d
mozlint/clippy: update of the test to reflect the new output r=marco
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.