Closed Bug 1645092 Opened 4 years ago Closed 1 year ago

WebGLRenderingContext.getUniform() fails with "WebGL warning: getUniform: No active linked Program."

Categories

(Core :: Graphics: CanvasWebGL, defect, P2)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: jujjyl, Assigned: jgilbert)

Details

Attachments

(2 files)

glctx_getUniform.html
266.50 KB, text/html
Details
Bug 1645092 - Don't fail GetUniform if the program is not current.
48 bytes, text/x-phabricator-request
Details | Review
Attached file glctx_getUniform.html —

The function

GLctx.getUniform(program, location)

can be used to query the value of an uniform in the given program. (https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/getUniform)

However if one has no current program bound (GLctx.useProgram(null) is in effect), the above code will fail with a warning message

WebGL warning: getUniform: No active linked Program.

But since the function call GLctx.getUniform specifies the target program in the function parameter input arguments, whatever program is currently active should not matter.

(Works properly in Chrome)

The severity field is not set for this bug.
:jgilbert, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jgilbert)
Severity: -- → S3
Flags: needinfo?(jgilbert)
Priority: -- → P2
Assignee: nobody → jgilbert
Status: NEW → ASSIGNED

Backed out for causing build bustage.

[task 2022-11-30T04:47:34.796Z] 04:47:34     INFO -  Creating config.status
[task 2022-11-30T04:47:35.050Z] 04:47:35     INFO -  Reticulating splines...
[task 2022-11-30T04:47:35.752Z] 04:47:35     INFO -   0:00.73 File already read. Skipping: /builds/worker/checkouts/gecko/intl/components/moz.build
[task 2022-11-30T04:47:36.172Z] 04:47:36     INFO -   0:01.15 File already read. Skipping: /builds/worker/checkouts/gecko/gfx/angle/targets/angle_common/moz.build
[task 2022-11-30T04:47:36.573Z] 04:47:36    ERROR -  Traceback (most recent call last):
[task 2022-11-30T04:47:36.573Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1755, in _process_test_manifest
[task 2022-11-30T04:47:36.574Z] 04:47:36     INFO -      raise SandboxValidationError(
[task 2022-11-30T04:47:36.574Z] 04:47:36     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2022-11-30T04:47:36.574Z] 04:47:36     INFO -  ==============================
[task 2022-11-30T04:47:36.574Z] 04:47:36     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2022-11-30T04:47:36.574Z] 04:47:36     INFO -  ==============================
[task 2022-11-30T04:47:36.574Z] 04:47:36     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2022-11-30T04:47:36.575Z] 04:47:36     INFO -      /builds/worker/checkouts/gecko/dom/canvas/moz.build
[task 2022-11-30T04:47:36.575Z] 04:47:36     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2022-11-30T04:47:36.575Z] 04:47:36     INFO -      Test manifest (/builds/worker/checkouts/gecko/dom/canvas/test/webgl-conf/generated-mochitest.ini) lists test that does not exist: generated/test_2_conformance__uniforms__gl-get-uniform-non-current-program.html, generated/test_conformance__uniforms__gl-get-uniform-non-current-program.html
[task 2022-11-30T04:47:36.575Z] 04:47:36     INFO -  During handling of the above exception, another exception occurred:
[task 2022-11-30T04:47:36.576Z] 04:47:36    ERROR -  Traceback (most recent call last):
[task 2022-11-30T04:47:36.576Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 346, in <module>
[task 2022-11-30T04:47:36.576Z] 04:47:36     INFO -      sys.exit(main(sys.argv))
[task 2022-11-30T04:47:36.576Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 158, in main
[task 2022-11-30T04:47:36.576Z] 04:47:36     INFO -      return config_status(config)
[task 2022-11-30T04:47:36.577Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 297, in config_status
[task 2022-11-30T04:47:36.577Z] 04:47:36     INFO -      return config_status(args=[], **sanitized_config)
[task 2022-11-30T04:47:36.577Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 162, in config_status
[task 2022-11-30T04:47:36.577Z] 04:47:36     INFO -      definitions = list(definitions)
[task 2022-11-30T04:47:36.577Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 162, in emit
[task 2022-11-30T04:47:36.577Z] 04:47:36     INFO -      objs = list(emitfn(out))
[task 2022-11-30T04:47:36.578Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1547, in emit_from_context
[task 2022-11-30T04:47:36.578Z] 04:47:36     INFO -      for obj in self._process_test_manifests(context):
[task 2022-11-30T04:47:36.578Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1711, in _process_test_manifests
[task 2022-11-30T04:47:36.578Z] 04:47:36     INFO -      for obj in self._process_test_manifest(context, info, path, manifest):
[task 2022-11-30T04:47:36.579Z] 04:47:36     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1836, in _process_test_manifest
[task 2022-11-30T04:47:36.579Z] 04:47:36     INFO -      raise SandboxValidationError(
[task 2022-11-30T04:47:36.579Z] 04:47:36     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2022-11-30T04:47:36.579Z] 04:47:36     INFO -  ==============================
[task 2022-11-30T04:47:36.579Z] 04:47:36     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2022-11-30T04:47:36.580Z] 04:47:36     INFO -  ==============================
[task 2022-11-30T04:47:36.580Z] 04:47:36     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2022-11-30T04:47:36.580Z] 04:47:36     INFO -      /builds/worker/checkouts/gecko/dom/canvas/moz.build
[task 2022-11-30T04:47:36.580Z] 04:47:36     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2022-11-30T04:47:36.580Z] 04:47:36    ERROR -      Error processing test manifest file /builds/worker/checkouts/gecko/dom/canvas/test/webgl-conf/generated-mochitest.ini: Traceback (most recent call last):
[task 2022-11-30T04:47:36.581Z] 04:47:36     INFO -        File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1755, in _process_test_manifest
[task 2022-11-30T04:47:36.581Z] 04:47:36     INFO -          raise SandboxValidationError(
[task 2022-11-30T04:47:36.581Z] 04:47:36     INFO -      mozbuild.frontend.reader.SandboxValidationError:
[task 2022-11-30T04:47:36.581Z] 04:47:36     INFO -      ==============================
[task 2022-11-30T04:47:36.581Z] 04:47:36     INFO -      FATAL ERROR PROCESSING MOZBUILD FILE
[task 2022-11-30T04:47:36.581Z] 04:47:36     INFO -      ==============================
[task 2022-11-30T04:47:36.582Z] 04:47:36     INFO -      The error occurred while processing the following file or one of the files it includes:
[task 2022-11-30T04:47:36.582Z] 04:47:36     INFO -          /builds/worker/checkouts/gecko/dom/canvas/moz.build
[task 2022-11-30T04:47:36.582Z] 04:47:36     INFO -      The error occurred when validating the result of the execution. The reported error is:
[task 2022-11-30T04:47:36.582Z] 04:47:36     INFO -          Test manifest (/builds/worker/checkouts/gecko/dom/canvas/test/webgl-conf/generated-mochitest.ini) lists test that does not exist: generated/test_2_conformance__uniforms__gl-get-uniform-non-current-program.html, generated/test_conformance__uniforms__gl-get-uniform-non-current-program.html
[task 2022-11-30T04:47:38.448Z] 04:47:38     INFO -  *** Fix above errors and then restart with "./mach build"
[task 2022-11-30T04:47:38.569Z] 04:47:38    ERROR - Return code: 1
Flags: needinfo?(jgilbert)
Flags: needinfo?(jgilbert)
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f1899c7bd3b
Don't fail GetUniform if the program is not current. r=gfx-reviewers,lsalzman

https://hg.mozilla.org/mozilla-central/rev/2f1899c7bd3b

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: