1645114 - Don't throw exceptions from methods that return GeckoResult

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

When calling a method that returns a GeckoResult, it's a fair expectation that any errors will come via the returned GeckoResult instead via a thrown exception. If you have to handle both, it makes for some ugly code:

try {
    foo.bar().then(val -> {
        // do something with val
    }, ex -> {
        // error handling
    });
} catch (IllegalStateException e) {
   // more error handling
}

We should change any spots where we throw in these cases to fail the returned GeckoResult instead.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

See also bug 1644998 as one of the signatures that show this problem.

Comment 2

[Polly [:polly]]

Attachment: Bug 1645114 - for screenshot capture, include exception in failure result rather than throwing.

Also remove exception handling at call site in Android components - no need to catch exceptions for method that no longer throws.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/181b60bf152b
for screenshot capture, include exception in failure result rather than throwing. r=geckoview-reviewers,tthibaud,twhite

Comment 4

[Aron Cseh [:acseh]]

https://hg.mozilla.org/mozilla-central/rev/181b60bf152b