164527 - "function foo" unused

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

chb@frodo:~/mozilla/profile$ grep -r foo *
resources/content/profileSelection.js:function foo()
src/nsProfile.cpp:	 * 1) user creates a profile "foo" and the directory gets
named "foo".
src/nsProfile.cpp:	 * 3) user deletes the profile "foo", but chooses not to
delete the files on disk.  (they are given this option when deleting a profile)
src/nsProfile.cpp:	 * 4) user renames "bar" profile to "foo", but still uses the
directory named "bar" on disk
chb@frodo:~/mozilla/profile$

--> this function is unused and should be removed.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 96820 [details] [diff] [review]
patch

sr=bzbarsky; test well!

And make sure to get review from whoever wrote this function to start with (or
at least a clarification for why we have it).

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

taking bug

Ben, you wrote that function; what is it good for? Is the patch here OK with you?

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

sniff. my first and last easter egg. rest in peace.

(yes, remove it)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

done.

Comment 6

[K'Trina Medina]

Verified code fix