1645272 - [meta] Migrate our in-tree reftest-paged reftests into wpt

Status: ASSIGNED

(Core :: Layout, task, P3)

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Sorry that I should've noticed this earlier. I just realize that currently wpt printing reftests don't run in the same tier as our ordinary wpt reftests, so they don't have the same platform coverages.

By looking at this treeherder query on mozilla-central, I notice Wp is still tier2 on Linux, macOS, and Windows; no coverage on Android. That means if something breaks a wpt printing reftest, the offending patches won't be backout immediately. Though we might care less about printing on Android, but ideally we should run wpt printing reftest wherever the ordinary reftests run unless there are some obstacles to run them on Android.

Hiro, I feel we should suspend converting more reftest-print reftests to wpt unless Wp are promoted to Tier1 (at least on the three desktop platforms that support printing) per the above reasons. What do you think?

James, do we have any timeline to promote wpt printing reftests to Tier1? Any plan to support them on Android?

Comment 2

[James Graham [:jgraham]]

I'm happy to promote them to Tier-1 immediately. I just landed them as T-2 out of conservativeness.

I think that some additional work would be required to support Android. At the least I'm not sure the step where we write a PDF to disk is going to work on that platform.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Thank you both! Honestly I hadn't realized it at all. :/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Note about flexbox-single-column-4.html, Daniel and TYLin agreed on we don't need to upstream it, see bug 1649677 comment 2 and bug 1649677 comment 3.

Comment 6

[Frank Griffith Jr]

Hiro, Is this still an open issue? I see that all the dependencies have been closed. Cleaning up Epics and this stood out.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

right, you can see still a bunch of tests we need to migrate in the URL field (https://searchfox.org/mozilla-central/search?q=reftest-paged&path=&case=false&regexp=false).