Closed Bug 1645318 Opened 4 years ago Closed 4 years ago

Intermittent bugs/421885-1.xml == bugs/421885-1-ref.xml | image comparison, max difference: 65, number of differing pixels: 1024

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- wontfix
firefox85 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: nical)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered][stockwell unknown])

Attachments

(1 file)

Bug 1645318 - Adjust reftest references.
47 bytes, text/x-phabricator-request
Details | Review

Did the recent failures start with the push of bug 1672216 and bug 1672214? They are all with geckoview and webrender enabled.

Flags: needinfo?(nical.bugzilla)
Keywords: regression
Has Regression Range: --- → yes
Severity: normal → --
Priority: P5 → --

I think that this is caused by the patch in bug 1672214 allowing alpha texture arrays to be resized. The unfortunately sampling will come out slightly differently depending on the size of the texture, which explains the intermittent nature of the issue. The patch in bug 1673387 fixes that.

Assignee: nobody → nical.bugzilla
Depends on: 1673387
Flags: needinfo?(nical.bugzilla)

There are 30 total failures in the last 7 days on

  • android-hw-p2-8-0-android-aarch64-shippable-qr opt
  • android-hw-p2-8-0-android-aarch64-qr opt and debug

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=321669121&repo=mozilla-central&lineNumber=8119

[task 2020-11-13T06:09:03.155Z] 06:09:03 INFO - REFTEST TEST-START | layout/reftests/bugs/421885-1.xml == layout/reftests/bugs/421885-1-ref.xml
[task 2020-11-13T06:09:03.155Z] 06:09:03 INFO - REFTEST TEST-LOAD | http://10.7.205.245:8854/tests/layout/reftests/bugs/421885-1.xml | 1147 / 2155 (53%)
[task 2020-11-13T06:09:03.155Z] 06:09:03 INFO - REFTEST TEST-LOAD | http://10.7.205.245:8854/tests/layout/reftests/bugs/421885-1-ref.xml | 1147 / 2155 (53%)
[task 2020-11-13T06:09:03.155Z] 06:09:03 INFO - REFTEST INFO | REFTEST fuzzy test (63, 1024) <= (65, 1024) <= (64, 1024)
[task 2020-11-13T06:09:03.155Z] 06:09:03 WARNING - REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/421885-1.xml == layout/reftests/bugs/421885-1-ref.xml | image comparison, max difference: 65, number of differing pixels: 1024

Nicolas I see both bugs mentioned above are fixed, however this is still failing. Can you take a look?

Flags: needinfo?(nical.bugzilla)
Whiteboard: [retriggered] → [retriggered][stockwell needswork:owner]

Depends on D97132

Flags: needinfo?(nical.bugzilla)
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/801a132e9ae7
Adjust reftest references. r=jnicol

https://hg.mozilla.org/mozilla-central/rev/801a132e9ae7

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

The patch landed in nightly and beta is affected.
:nical, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nical.bugzilla)

Feel free to uplift but I don't think adding some fuzziness to a reftest expectation to paper over it intermittently going over the fuzzy threshold is worth bothering to uplift.

status-firefox84: affected → wontfix
Flags: needinfo?(nical.bugzilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: