Closed Bug 1645361 Opened 5 years ago Closed 4 years ago

browser.contacts.quickSearch fails when address books are invalid.

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

Product:
Thunderbird
Component:
Add-Ons: Extensions API
Type:
defect

Tracking

(thunderbird_esr68?)

Status:
RESOLVED DUPLICATE of bug 1679464
Tracking Flags:
Tracking Status
thunderbird_esr68 ? ---

People

(Reporter: standard8, Unassigned)

References

Details

We've just started using browser.contacts.quickSearch in Conversations. I've just received two reports that this is busting Conversations when users have Exquilla installed. One of those had Exquilla with an out-of-date license.

The exception that gets thrown is:

[Exception... "JavaScript component does not have a method named: "Symbol.iterator"'JavaScript component does not have a method named: "Symbol.iterator"' when calling method: [nsISimpleEnumerator::Symbol.iterator]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: chrome://messenger/content/parent/ext-addressBook.js :: quickSearch :: line 556"  data: no] ext-addressBook.js:556:49
    quickSearch chrome://messenger/content/parent/ext-addressBook.js:556
    quickSearch self-hosted:1005
    result resource://gre/modules/ExtensionParent.jsm:1139
    withPendingBrowser resource://gre/modules/ExtensionParent.jsm:770
    result resource://gre/modules/ExtensionParent.jsm:1139
    withTiming resource://gre/modules/ExtensionParent.jsm:1100
    call resource://gre/modules/ExtensionParent.jsm:1138
    InterpretGeneratorResume self-hosted:1284
    AsyncFunctionNext self-hosted:839
{…}

That comes from here:

https://searchfox.org/comm-esr68/rev/c0efa7116ed4cbb1f313d6305b5650d6eba4d0d0/mail/components/extensions/parent/ext-addressBook.js#556-557

Whilst I've implemented a try/catch work around in Conversations, that stops the API working completely, so some functionality would be lost.

I think this just affects the 68 branch, the latest code seems different assuming that wouldn't throw on an error:

https://searchfox.org/comm-central/rev/83ae42aa38bc39143b0f6d93bb69a40094c4b515/mail/components/extensions/parent/ext-addressBook.js#554-572

See Also: → 1695297

Can you confirm this is fixed in 78+?

Flags: needinfo?(standard8)

Hmm, I think we actually ended up fixing this in bug 1679464, and in Exquilla itself. I haven't had any more reports since then.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(standard8)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.