Closed Bug 1645479 Opened 4 years ago Closed 4 years ago

Don't use SECITEM_MakeItem in secutil.c

Categories

(NSS :: Libraries, defect, P1)

3.54

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kjacobs, Assigned: kjacobs)

Details

Attachments

(1 file)

Bug 1603042 added a call to SECITEM_MakeItem (which is exported by nssutil) in secutil.c.

This breaks some Firefox builds, which call similar functions through nss directly. The simple solution is to just use SECItem_CopyItem instead.

This patch converts a call to SECITEM_MakeItem to use SECITEM_CopyItem instead. Using the former works fine in NSS CI, but causes build failures in mozilla-central due to differences in how both symbols are exported (i.e. when folding nssutil into nss).

Severity: -- → S3
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: