1645485 - [wpt-sync] Sync PR 24134 - client hints: Rework how persistent settings are communicated to renderer

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24134 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24134
Details from upstream follow.

Maks Orlovich <[e-mail]> wrote:

client hints: Rework how persistent settings are communicated to renderer

Before this CL, the entire settings map was sent to the renderer,
it then parsed accept-ch, and sent IPCs to the browser to persist
settings.

This has following downsides:

1. client-hint settings map can leak history to render (I don't know
   if there are other sources of that, probably, so maybe not such a
   big deal)
2. If this becomes popular, map size would be a performance risk
3. This requires trusting renderer to update client hint settings.

Instead, this uses existing network service hook to parse accept-ch
(which was needed for navigation redirects), and the browser persists
the results and sends the relevant client hint configuration to the
renderer with CommitParams. The IPC for renderer to write config
is therefore removed.

This required teaching the browser code to behave more consistently
with some flags (lang, accept-ch-lifetime support).

Change-Id: I421b3c07d4644e179a0f6a26088e44c55f68f7d0

Reviewed-on: https://chromium-review.googlesource.com/2081628
WPT-Export-Revision: bba88535f5ef6e6dc60119a0f43868b1b0c3bbdb

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e87b434c6d2191d79275d37a7da4e51f785f64c3

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89107c9a6027
[wpt PR 24134] - client hints: Rework how persistent settings are communicated to renderer, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/89107c9a6027