Closed Bug 164565 Opened 22 years ago Closed 22 years ago

In common getPlatform, return win for OS/2

Categories

(SeaMonkey :: Installer, defect)

x86
OS/2
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mkaply, Assigned: mkaply)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

On OS/2, for the languages JARs, we use the en-win versions.

In share.t in packager/common, the default case is unix.

My fix here is to add a check for OS/2 in share.t

I think this is preferred because this file is only used for the 
regChrome for the langpacks.
Attached patch PatchSplinter Review
If OS/2, return win
QA Contact: bugzilla → ktrina
Keywords: patch, review
Your description says to return win, your patch returns os2. Is that doing what
you want? I don't think you've created an en-os2.jar did you?

Reassigning to you to check in, I'll r= or sr= if this patch does what you want.
Assignee: dveditz → mkaply
Would you believe I attached the wrong patch?

I swear the real patch changes it to win.
OK, I sr=dveditz (and moa=) if the patch you check in changes the os2 return
value to win
Comment on attachment 96644 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to 1.2a (we're down to the wire. land
quickly or miss the boat)
Attachment #96644 - Flags: approval+
This is fixed
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Verified fixed (per reporter)
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Blocks: 154500
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: