Closed
Bug 164565
Opened 22 years ago
Closed 22 years ago
In common getPlatform, return win for OS/2
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mkaply, Assigned: mkaply)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
527 bytes,
patch
|
asa
:
approval+
|
Details | Diff | Splinter Review |
On OS/2, for the languages JARs, we use the en-win versions. In share.t in packager/common, the default case is unix. My fix here is to add a check for OS/2 in share.t I think this is preferred because this file is only used for the regChrome for the langpacks.
Assignee | ||
Comment 1•22 years ago
|
||
If OS/2, return win
Updated•22 years ago
|
QA Contact: bugzilla → ktrina
Updated•22 years ago
|
Comment 2•22 years ago
|
||
Your description says to return win, your patch returns os2. Is that doing what you want? I don't think you've created an en-os2.jar did you? Reassigning to you to check in, I'll r= or sr= if this patch does what you want.
Assignee: dveditz → mkaply
Assignee | ||
Comment 3•22 years ago
|
||
Would you believe I attached the wrong patch? I swear the real patch changes it to win.
Comment 4•22 years ago
|
||
OK, I sr=dveditz (and moa=) if the patch you check in changes the os2 return value to win
Comment 5•22 years ago
|
||
Comment on attachment 96644 [details] [diff] [review] Patch a=asa (on behalf of drivers) for checkin to 1.2a (we're down to the wire. land quickly or miss the boat)
Attachment #96644 -
Flags: approval+
Assignee | ||
Comment 6•22 years ago
|
||
This is fixed
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•