1645668 - Sound indicator doesn't work sometimes

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Avlasenko Vitaliy]

Attachment: bandicam 2020-06-14 11-22-19-053.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Open music on https://vk.com and play some song.

Actual results:

Music indicator disappears after few seconds even though the song is still playing. It reappear if rewind a song.

Expected results:

Indicator will ALWAYS be shown.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Alastor Wu [:alwu]]

I can reproduce this.

Comment 4

[tustamido]

This bug started in Fx 72.

With mozregresssion:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4e3a2ac7a81d5fea15fe332f478037d8d4b0e925&tochange=6e1a7f2f6bb2a106ba490556ee1effd411726651

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1645668 - part1 : reset audio track audible state when aborting current load.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1645668 - part2 : add test.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe9225d28223
part1 : reset audible state when aborting current load. r=bryce
https://hg.mozilla.org/integration/autoland/rev/3feca854d60f
part2 : add test. r=bryce

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fe9225d28223
https://hg.mozilla.org/mozilla-central/rev/3feca854d60f

Comment 9

[Alastor Wu [:alwu]]

Comment on attachment 9160249 [details]
Bug 1645668 - part1 : reset audio track audible state when aborting current load.

Beta/Release Uplift Approval Request

• User impact if declined: In some websites, the sound indicator would not appear even if the website is playing audio.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It resets the media element's internal state that is supposed to be reset when we abort the current load. It doesn't introduce any new functionality change and new feature.
• String changes made/needed: None

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9160249 [details]
Bug 1645668 - part1 : reset audio track audible state when aborting current load.

Approved for 79.0b3. Thanks for including a test.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f00bb12f9f8e
https://hg.mozilla.org/releases/mozilla-beta/rev/ecf6eea8a56f

Comment 12

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I reproduced the issue on Firefox Nightly 79.0a1 (2020-06-14) under macOS 10.15.5 using the STR from Comment 0.

This issue is fixed on Firefox 79.0b3 and Firefox 80.0a1 (2020-07-02). Tests were performed under macOS 10.15.5, Ubuntu 20.04 and Windows 10.