1645687 - Quota meter in folder props has a too big border radius

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Attachment: Quota.png

The in bug 841906 introduced quota meter styling uses a too big border radius. We have no other boxes with such a border radius and should use a standard of 2px.

With very low or very high quotas it's almost not visible because the radius hides too much, see screenshot for comparison.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1645687-quota-border-radius.patch

Use 2px instead of 99px for the border radius.

[Approval Request Comment]
Regression caused by (bug #): Bug 841906
User impact if declined: Read comment 0
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): no, only a CSS value change.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9156572 [details] [diff] [review]
1645687-quota-border-radius.patch

Review of attachment 9156572 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, sounds good to me.
I proposed the fully rounded borders as I personally like them for progress bars since it creates a visual distinctions with input fields.
It's mostly a personal preference, so the issue you pointed out is very valid.
Thanks.

There's a typo in the commit message, can you update it with:  "Bug 1645687 - Use 2px border radius for the quota meter progress bar. r=aleca"

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1645687-quota-border-radius.patch

Fixed the commit message.

[Approval Request Comment]
Regression caused by (bug #): Bug 841906
User impact if declined: Read comment 0
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): no, only a CSS value change.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2d069be0478c
Use 2px border radius for the quota meter progress bar. r=aleca

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9156787 [details] [diff] [review]
1645687-quota-border-radius.patch

Approved for beta

Comment 6

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b4b0572782d0