1645904 - DocAccessibleParent::RecvVirtualCursorChangeEvent() swaps aReason and aBoundaryType

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Alexey Izbyshev]

Svace static analyzer reported that the call at https://hg.mozilla.org/mozilla-central/file/4fdcaa5d6ec3/accessible/ipc/DocAccessibleParent.cpp#l424 passes aBoundaryType and aReason (in that order) as the last two int16_t arguments, but xpcAccVirtualCursorChangeEvent constructor expects to receive them in the reverse order (IIUC it's generated from https://hg.mozilla.org/mozilla-central/file/4fdcaa5d6ec3/accessible/interfaces/nsIAccessibleVirtualCursorChangeEvent.idl).
I couldn't find any place that swaps them back, which would make it just a cosmetic issue, so it seems to be a real one.

Comment 1

[James Teh [:Jamie]]

This is definitely wrong. However, I think the xpcom event is now only used by our automated tests, which probably don't look at the reason and boundary type. Eitan, is this correct?

Comment 2

[Eitan Isaacson [:eeejay]]

Oops. Yes that is correct.

Comment 3

[Neia Finch]

Attachment: Bug 1645904 - Fix swapped parameters for nsIAccessibleVirtualCursorChangeEvent r?eeejay

The fields are unused, but there's no reason to propagate them
incorrectly.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:eeejay, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f7224434545
Fix swapped parameters for nsIAccessibleVirtualCursorChangeEvent r=eeejay

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4f7224434545