Closed Bug 1645996 Opened 8 months ago Closed 8 months ago

build failure with missing namespace on MakeSpan since 1643474

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

VERIFIED FIXED
mozilla79
Tracking Status
firefox-esr68 --- unaffected
firefox77 --- unaffected
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: gaston, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Since b7 (b5 was fine - also witnessed with tb 78b1 build4), my builds (OpenBSD, clang8) consistenty fail:

In file included from Unified_cpp_widget_gtk0.cpp:110:
/usr/obj/ports/firefox-78.0beta7/firefox-78.0/widget/gtk/WidgetStyleCache.cpp:640:35: error: use of undeclared identifier 'MakeSpan'; did you mean 'mozilla::MakeSpan'?
      GetGtkHeaderBarButtonLayout(MakeSpan(buttonLayout), nullptr);
                                  ^~~~~~~~
                                  mozilla::MakeSpan
/usr/obj/ports/firefox-78.0beta7/build-amd64/dist/include/mozilla/Span.h:907:19: note: 'mozilla::MakeSpan' declared here
Span<ElementType> MakeSpan(ElementType (&aArr)[N]) {
                  ^
1 error generated.

adding the missing explicit mozilla:: prefix fixes the build for me.

i see in https://hg.mozilla.org/releases/mozilla-beta/rev/947b4a403f23 that the namespace prefix was not consistently added - maybe it should be present for all occurences ?

Thanks for reporting, yeah, that namespace qualification should be there, probably unified builds mask this issue.

Assignee: nobody → emilio
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c06cf658449
Add explicit namespace qualification for MakeSpan in WidgetStyleCache.
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

Please request uplift so we get this fix in 78.

Flags: needinfo?(emilio)

Comment on attachment 9156940 [details]
Bug 1645996 - Add explicit namespace qualification for MakeSpan in WidgetStyleCache.

Beta/Release Uplift Approval Request

  • User impact if declined: Some builds break.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple build fix.
  • String changes made/needed: none

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build fix
  • User impact if declined: none
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple build fix
  • String or UUID changes made by this patch: none
Flags: needinfo?(emilio)
Attachment #9156940 - Flags: approval-mozilla-esr78?
Attachment #9156940 - Flags: approval-mozilla-beta?

Comment on attachment 9156940 [details]
Bug 1645996 - Add explicit namespace qualification for MakeSpan in WidgetStyleCache.

Thanks emilio :)

approved for 78.0b9

Attachment #9156940 - Flags: approval-mozilla-esr78?
Attachment #9156940 - Flags: approval-mozilla-beta?
Attachment #9156940 - Flags: approval-mozilla-beta+

can confirm that 78.0b9 builds fine on OpenBSD, thanks!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.