1645996 - build failure with missing namespace on MakeSpan since 1643474

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Landry Breuil (:gaston)]

Since b7 (b5 was fine - also witnessed with tb 78b1 build4), my builds (OpenBSD, clang8) consistenty fail:

In file included from Unified_cpp_widget_gtk0.cpp:110:
/usr/obj/ports/firefox-78.0beta7/firefox-78.0/widget/gtk/WidgetStyleCache.cpp:640:35: error: use of undeclared identifier 'MakeSpan'; did you mean 'mozilla::MakeSpan'?
      GetGtkHeaderBarButtonLayout(MakeSpan(buttonLayout), nullptr);
                                  ^~~~~~~~
                                  mozilla::MakeSpan
/usr/obj/ports/firefox-78.0beta7/build-amd64/dist/include/mozilla/Span.h:907:19: note: 'mozilla::MakeSpan' declared here
Span<ElementType> MakeSpan(ElementType (&aArr)[N]) {
                  ^
1 error generated.

adding the missing explicit mozilla:: prefix fixes the build for me.

i see in https://hg.mozilla.org/releases/mozilla-beta/rev/947b4a403f23 that the namespace prefix was not consistently added - maybe it should be present for all occurences ?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1645996 - Add explicit namespace qualification for MakeSpan in WidgetStyleCache.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Thanks for reporting, yeah, that namespace qualification should be there, probably unified builds mask this issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c06cf658449
Add explicit namespace qualification for MakeSpan in WidgetStyleCache.

Comment 4

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Set release status flags based on info from the regressing bug 1643474

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6c06cf658449

Comment 6

[Julien Cristau [:jcristau]]

Please request uplift so we get this fix in 78.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9156940 [details]
Bug 1645996 - Add explicit namespace qualification for MakeSpan in WidgetStyleCache.

Beta/Release Uplift Approval Request

• User impact if declined: Some builds break.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple build fix.
• String changes made/needed: none

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build fix
• User impact if declined: none
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple build fix
• String or UUID changes made by this patch: none

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9156940 [details]
Bug 1645996 - Add explicit namespace qualification for MakeSpan in WidgetStyleCache.

Thanks emilio :)

approved for 78.0b9

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eaadc43b226e

Comment 10

[Landry Breuil (:gaston)]

can confirm that 78.0b9 builds fine on OpenBSD, thanks!