Closed Bug 1646027 Opened 4 years ago Closed 4 years ago

Request mimeType should be sent on response start

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: farooqbckk, Assigned: farooqbckk)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

temp.diff
3.51 KB, patch
Details | Diff | Splinter Review
temp.diff
5.78 KB, patch
Details | Diff | Splinter Review
set-event-stream-flag.diff
8.64 KB, patch
Details | Diff | Splinter Review
image.png
18.47 KB, image/png
Details
mimetypeerror.PNG
42.33 KB, image/png
Details
Bug 1646027 - Request mimeType should be sent on response start. r=Honza,bomsy
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Currently, the NetworkEventActor sends mimeType to UI as part of the request's response headers, which are sent to UI when the response is completely received:

https://searchfox.org/mozilla-central/source/devtools/server/actors/network-monitor/network-event.js#510

SSE inspector brings up the usecase where we need mimeType as early as possible. The earliest we get it is in response's rawHeaders as Content-Type:

https://searchfox.org/mozilla-central/source/devtools/server/actors/network-monitor/network-event.js#397

Blocks: netmonitor-sse-inspector
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Attached patch temp.diff — — Splinter Review

@Farooq, please see my attached patch.

  • It shows how to send the contentType / mimeType to the client with responseStart packet
  • The way how the Content-Type header is parsed using (substr must be improved, of course)
  • There is a console.log in the FirefoxDataProvider that should show the value in the BrowserConsole

Does it work for you?

Honza

Assignee: nobody → odvarko
Flags: needinfo?(farooqbckk)

Yep, it works and logs at the right time. However, it is not available to the redux state at the same time (probably because the queue we add mimeType to, is flushed to state when the response is complete). I guess we would need to dispatch a separate action sooner just to handle this case ...?

Flags: needinfo?(farooqbckk)
Attached patch temp.diff — — Splinter Review

Follow up patch firing setEventStreamFlag action at responseStart time.

Honza

The patch has been done together at a meeting today.
Farooq, does it solve the problem?

Honza

Flags: needinfo?(farooqbckk)

Oopsy ... same issue: request coming in after setEventStreamFlag in responseStart is fired.

That was weird but I realized addRequest action is batched. So everything works as expected if addRequest is fired with batching disabled, even the existing solution using connectionOpen event.

In other words, this bug can be fixed by just passing false here: https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/connector/firefox-data-provider.js#129

I am wondering If:

  1. Not batching this action safe.
  2. We should fire setEventStreamFlag in responseStart instead or keep it as is in connectionOpen event
Flags: needinfo?(farooqbckk)

(In reply to Farooq AR from comment #5)

Oopsy ... same issue: request coming in after setEventStreamFlag in responseStart is fired.

How can I reproduce this?

When using the following STRs it works for me

  1. Load https://farooqar.github.io/sse-echo/
  2. Open the Network panel
  3. Click the "Connect!" button
  4. Observer order of logs in the Browser Console
    (the screenshot is coming)

I am attaching the patch I am using.

Honza

Attached image mimetypeerror.PNG —

I think you'll be able to see the bug on a local demo

Please try running this on your local machine and lemme know if you face any problems: https://github.com/farooqar/sse-echo

Farooq, it looks like we forgot to make sure that setEventStreamFlag is also batched.

You should do the following:

function setEventStreamFlag(id, batch) {
  return {
    type: SET_EVENT_STREAM_FLAG,
    id,
    meta: { batch },
  };
}

and pass true as the second argument when calling setEvenStreamFlag

        if (mimeType == "sse-mimetype") {
          if (this.actionsEnabled && this.actions.setEventStreamFlag) {
            await this.actions.setEventStreamFlag(actor, true);
          }
        }

Does it help?

Honza

Flags: needinfo?(farooqbckk)

Ah yes, my bad. That works. Thanks!

Flags: needinfo?(farooqbckk)

Updating the assignee person

Honza

Assignee: odvarko → farooqbckk
Status: NEW → ASSIGNED
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d7e94b15360
Request mimeType should be sent on response start. r=Honza,bomsy,devtools-backward-compat-reviewers

Backed out changeset 4d7e94b15360 (bug 1646027) for browser_webconsole_stubs_network_event.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=mochitest%2Cdevtools&fromchange=cc4b615e1a1a4c6d7d3e11907199f9caf655ae8d&tochange=6de284c9eff0e334cd8e89f28c1cb89cced46254&selectedTaskRun=I1pE4EVlTEa2aAxB53BzmQ.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/6de284c9eff0e334cd8e89f28c1cb89cced46254

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308956466&repo=autoland&lineNumber=10986

[task 2020-07-08T10:33:55.211Z] 10:33:55     INFO - TEST-START | devtools/client/webconsole/test/browser/browser_webconsole_stubs_network_event.js
[task 2020-07-08T10:33:55.280Z] 10:33:55     INFO - GECKO(1259) | [Child 1342: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7efdf5a84c00 == 2 [pid = 1342] [id = {d482b502-0369-48a4-b96c-41e0aa621dfc}]
[task 2020-07-08T10:33:55.280Z] 10:33:55     INFO - GECKO(1259) | [Child 1342: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x7efe14e93350) [pid = 1342] [serial = 394] [outer = (nil)]
[task 2020-07-08T10:33:55.280Z] 10:33:55     INFO - GECKO(1259) | [Child 1342: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x7efdf5a85c00) [pid = 1342] [serial = 395] [outer = 0x7efe14e93350]
[task 2020-07-08T10:33:55.438Z] 10:33:55     INFO - GECKO(1259) | [Child 1342: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x7efdf68adc00) [pid = 1342] [serial = 396] [outer = 0x7efe14e93350]
[task 2020-07-08T10:33:55.715Z] 10:33:55     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f589962b800 == 8 [pid = 1259] [id = {802e9783-f9f9-4c2d-a9fd-76f21c5a2135}]
[task 2020-07-08T10:33:55.715Z] 10:33:55     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 18 (0x7f589fc14300) [pid = 1259] [serial = 1072] [outer = (nil)]
[task 2020-07-08T10:33:55.715Z] 10:33:55     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 19 (0x7f589a9c8800) [pid = 1259] [serial = 1073] [outer = 0x7f589fc14300]
[task 2020-07-08T10:33:55.796Z] 10:33:55     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 20 (0x7f589a9f5000) [pid = 1259] [serial = 1074] [outer = 0x7f589fc14300]
[task 2020-07-08T10:33:55.885Z] 10:33:55     INFO - GECKO(1259) | [Parent 1259, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp, line 3757
[task 2020-07-08T10:33:56.021Z] 10:33:56     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f589a9f3c00 == 9 [pid = 1259] [id = {2d0cf970-fd5a-4a22-8476-0338f4816d0d}]
[task 2020-07-08T10:33:56.022Z] 10:33:56     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 21 (0x7f589fc144d0) [pid = 1259] [serial = 1075] [outer = (nil)]
[task 2020-07-08T10:33:56.022Z] 10:33:56     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 22 (0x7f589b898400) [pid = 1259] [serial = 1076] [outer = 0x7f589fc144d0]
[task 2020-07-08T10:33:56.224Z] 10:33:56     INFO - GECKO(1259) | [Parent 1259, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp, line 1131
[task 2020-07-08T10:33:56.530Z] 10:33:56     INFO - GECKO(1259) | [Child 1504: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f4c45d21c00 == 0 [pid = 1504] [id = {9fdd7dcd-68fd-442e-b880-bcc5821fea98}] [url = data:text/html;charset=utf-8,stub generation]
[task 2020-07-08T10:33:56.530Z] 10:33:56     INFO - GECKO(1259) | [Child 1504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f4c45d28c00) [pid = 1504] [serial = 231] [outer = (nil)] [url = about:blank]
[task 2020-07-08T10:33:56.530Z] 10:33:56     INFO - GECKO(1259) | [Child 1504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f4c45d1f400) [pid = 1504] [serial = 228] [outer = (nil)] [url = about:blank]
[task 2020-07-08T10:33:56.673Z] 10:33:56     INFO - GECKO(1259) | [Parent 1259, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, nullptr) failed with result 0x804B000A (NS_ERROR_MALFORMED_URI): file /builds/worker/checkouts/gecko/extensions/permissions/Permission.cpp, line 46
[task 2020-07-08T10:33:56.673Z] 10:33:56     INFO - GECKO(1259) | [Parent 1259, Main Thread] WARNING: NS_ENSURE_TRUE(principal) failed: file /builds/worker/checkouts/gecko/extensions/permissions/Permission.cpp, line 58
[task 2020-07-08T10:33:56.680Z] 10:33:56     INFO - GECKO(1259) | [Child 1504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7f4c64093350) [pid = 1504] [serial = 227] [outer = (nil)] [url = http://example.com/browser/devtools/client/webconsole/test/browser/stub-generators/test-css-message.html]
[task 2020-07-08T10:33:56.881Z] 10:33:56     INFO - GECKO(1259) | [Child 1504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7f4c45d97c00) [pid = 1504] [serial = 229] [outer = (nil)] [url = http://example.com/browser/devtools/client/webconsole/test/browser/stub-generators/test-css-message.html]
[task 2020-07-08T10:33:56.998Z] 10:33:56     INFO - GECKO(1259) | [Child 1504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x7f4c640936f0) [pid = 1504] [serial = 230] [outer = (nil)] [url = data:text/html;charset=utf-8,stub generation]
[task 2020-07-08T10:33:57.713Z] 10:33:57     INFO - GECKO(1259) | [Parent 1259, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp, line 1605
[task 2020-07-08T10:33:58.099Z] 10:33:58     INFO - GECKO(1259) | [Child 1436: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7f6293761800) [pid = 1436] [serial = 384] [outer = (nil)] [url = about:blank]
[task 2020-07-08T10:33:58.101Z] 10:33:58     INFO - GECKO(1259) | [Child 1436: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f6293441800) [pid = 1436] [serial = 379] [outer = (nil)] [url = about:blank]
[task 2020-07-08T10:33:58.102Z] 10:33:58     INFO - GECKO(1259) | [Child 1436: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f6293766400) [pid = 1436] [serial = 382] [outer = (nil)] [url = http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html]
[task 2020-07-08T10:33:58.200Z] 10:33:58     INFO - GECKO(1259) | [Child 1436: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7f6291e909a0) [pid = 1436] [serial = 383] [outer = (nil)] [url = about:blank]
[task 2020-07-08T10:33:59.301Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 21 (0x7f589a9d0c00) [pid = 1259] [serial = 1068] [outer = (nil)] [url = about:blank]
[task 2020-07-08T10:33:59.302Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 20 (0x7f589b896c00) [pid = 1259] [serial = 1066] [outer = (nil)] [url = about:blank]
[task 2020-07-08T10:33:59.302Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 19 (0x7f589a9f7400) [pid = 1259] [serial = 1064] [outer = (nil)] [url = about:devtools-toolbox]
[task 2020-07-08T10:33:59.310Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f589a9cf800 == 8 [pid = 1259] [id = {a075565c-7fb2-4a06-80a3-9fc92afe44af}] [url = about:devtools-toolbox]
[task 2020-07-08T10:33:59.458Z] 10:33:59     INFO - GECKO(1259) | console.warn: "IGNORED REDUX ACTION:" ({type:"AUTOCOMPLETE_CLEAR"})
[task 2020-07-08T10:33:59.479Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/JSWindowActorProtocol.cpp, line 172
[task 2020-07-08T10:33:59.479Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/JSWindowActorProtocol.cpp, line 172
[task 2020-07-08T10:33:59.509Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 18 (0x7f589fc14130) [pid = 1259] [serial = 1067] [outer = (nil)] [url = about:devtools-toolbox]
[task 2020-07-08T10:33:59.509Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f589a9d0800 == 7 [pid = 1259] [id = {28660002-670e-4ad4-aba8-b4bc7cdef5e6}] [url = chrome://devtools/content/webconsole/index.html]
[task 2020-07-08T10:33:59.510Z] 10:33:59     INFO - GECKO(1259) | [Parent 1259: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 17 (0x7f589fc14fb0) [pid = 1259] [serial = 1070] [outer = (nil)] [url = chrome://devtools/content/webconsole/index.html]
[task 2020-07-08T10:33:59.525Z] 10:33:59     INFO - TEST-INFO | started process screentopng
[task 2020-07-08T10:33:59.906Z] 10:33:59     INFO - TEST-INFO | screentopng: exit 0
[task 2020-07-08T10:33:59.907Z] 10:33:59     INFO - Buffered messages logged at 10:33:55
[task 2020-07-08T10:33:59.907Z] 10:33:59     INFO - Entering test bound 
[task 2020-07-08T10:33:59.907Z] 10:33:59     INFO - Check networkEvent.js
[task 2020-07-08T10:33:59.907Z] 10:33:59     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/webconsole/test/browser/stub-generators/test-network-event.html
[task 2020-07-08T10:33:59.907Z] 10:33:59     INFO - Tab added and finished loading
[task 2020-07-08T10:33:59.908Z] 10:33:59     INFO - Opening the toolbox
[task 2020-07-08T10:33:59.908Z] 10:33:59     INFO - Buffered messages logged at 10:33:57
[task 2020-07-08T10:33:59.910Z] 10:33:59     INFO - Toolbox opened and focused
[task 2020-07-08T10:33:59.910Z] 10:33:59     INFO - Buffered messages logged at 10:33:59
[task 2020-07-08T10:33:59.910Z] 10:33:59     INFO - Removing tab.
[task 2020-07-08T10:33:59.910Z] 10:33:59     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-07-08T10:33:59.910Z] 10:33:59     INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-07-08T10:33:59.910Z] 10:33:59     INFO - Tab removed and finished closing
[task 2020-07-08T10:33:59.910Z] 10:33:59     INFO - Buffered messages finished
[task 2020-07-08T10:33:59.913Z] 10:33:59     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_stubs_network_event.js | "GET request" packet has expected value - Got {
[task 2020-07-08T10:33:59.914Z] 10:33:59     INFO -   "type": "networkEvent",
[task 2020-07-08T10:33:59.914Z] 10:33:59     INFO -   "timeStamp": 1572867483805,
[task 2020-07-08T10:33:59.914Z] 10:33:59     INFO -   "node": null,
[task 2020-07-08T10:33:59.914Z] 10:33:59     INFO -   "actor": "server0.conn0.netEvent4",
[task 2020-07-08T10:33:59.914Z] 10:33:59     INFO -   "discardRequestBody": true,
[task 2020-07-08T10:33:59.915Z] 10:33:59     INFO -   "discardResponseBody": true,
[task 2020-07-08T10:33:59.915Z] 10:33:59     INFO -   "startedDateTime": "2019-11-04T11:06:34.542Z",
[task 2020-07-08T10:33:59.915Z] 10:33:59     INFO -   "request": {
[task 2020-07-08T10:33:59.915Z] 10:33:59     INFO -     "url": "http://example.com/inexistent.html",
[task 2020-07-08T10:33:59.916Z] 10:33:59     INFO -     "method": "GET",
[task 2020-07-08T10:33:59.916Z] 10:33:59     INFO -     "headersSize": 396
[task 2020-07-08T10:33:59.916Z] 10:33:59     INFO -   },
[task 2020-07-08T10:33:59.916Z] 10:33:59     INFO -   "isXHR": false,
[task 2020-07-08T10:33:59.916Z] 10:33:59     INFO -   "cause": {
[task 2020-07-08T10:33:59.917Z] 10:33:59     INFO -     "type": "img",
[task 2020-07-08T10:33:59.917Z] 10:33:59     INFO -     "loadingDocumentUri": "http://example.com/browser/devtools/client/webconsole/test/browser/stub-generators/test-network-event.html",
[task 2020-07-08T10:33:59.917Z] 10:33:59     INFO -     "lastFrame": {
[task 2020-07-08T10:33:59.917Z] 10:33:59     INFO -       "filename": "http://example.com/browser/devtools/client/webconsole/test/browser/stub-generators/test-network-event.html",
[task 2020-07-08T10:33:59.918Z] 10:33:59     INFO -       "lineNumber": 3,
[task 2020-07-08T10:33:59.918Z] 10:33:59     INFO -       "columnNumber": 1,
[task 2020-07-08T10:33:59.919Z] 10:33:59     INFO -       "functionName": "triggerPacket",
[task 2020-07-08T10:33:59.919Z] 10:33:59     INFO -       "asyncCause": null
[task 2020-07-08T10:33:59.920Z] 10:33:59     INFO -     },
[task 2020-07-08T10:33:59.920Z] 10:33:59     INFO -     "stacktraceAvailable": true
[task 2020-07-08T10:33:59.920Z] 10:33:59     INFO -   },
[task 2020-07-08T10:33:59.921Z] 10:33:59     INFO -   "response": {
[task 2020-07-08T10:33:59.921Z] 10:33:59     INFO -     "httpVersion": "HTTP/1.1",
[task 2020-07-08T10:33:59.922Z] 10:33:59     INFO -     "status": "404",
[task 2020-07-08T10:33:59.922Z] 10:33:59     INFO -     "statusText": "Not Found",
[task 2020-07-08T10:33:59.923Z] 10:33:59     INFO -     "headersSize": 160,
[task 2020-07-08T10:33:59.923Z] 10:33:59     INFO -     "remoteAddress": "127.0.0.1",
[task 2020-07-08T10:33:59.923Z] 10:33:59     INFO -     "remotePort": 8888,
[task 2020-07-08T10:33:59.924Z] 10:33:59     INFO -     "mimeType": "text/html;charset=utf-8",
[task 2020-07-08T10:33:59.925Z] 10:33:59     INFO -     "waitingTime": 2,
[task 2020-07-08T10:33:59.925Z] 10:33:59     INFO -     "content": {
[task 2020-07-08T10:33:59.926Z] 10:33:59     INFO -       "mimeType": "text/html; charset=utf-8"
[task 2020-07-08T10:33:59.926Z] 10:33:59     INFO -     },
[task 2020-07-08T10:33:59.927Z] 10:33:59     INFO -     "bodySize": 418,
[task 2020-07-08T10:33:59.927Z] 10:33:59     INFO -     "transferredSize": 578
[task 2020-07-08T10:33:59.927Z] 10:33:59     INFO -   },
[task 2020-07-08T10:33:59.928Z] 10:33:59     INFO -   "timings": {},
[task 2020-07-08T10:33:59.928Z] 10:33:59     INFO -   "updates": [
[task 2020-07-08T10:33:59.929Z] 10:33:59     INFO -     "eventTimings",
[task 2020-07-08T10:33:59.929Z] 10:33:59     INFO -     "requestCookies",
[task 2020-07-08T10:33:59.930Z] 10:33:59     INFO -     "requestHeaders",
[task 2020-07-08T10:33:59.930Z] 10:33:59     INFO -     "responseContent",
[task 2020-07-08T10:33:59.930Z] 10:33:59     INFO -     "responseCookies",
[task 2020-07-08T10:33:59.931Z] 10:33:59     INFO -     "responseHeaders",
[task 2020-07-08T10:33:59.931Z] 10:33:59     INFO -     "responseStart",
[task 2020-07-08T10:33:59.932Z] 10:33:59     INFO -     "securityInfo"
[task 2020-07-08T10:33:59.932Z] 10:33:59     INFO -   ],
[task 2020-07-08T10:33:59.933Z] 10:33:59     INFO -   "private": false,
[task 2020-07-08T10:33:59.933Z] 10:33:59     INFO -   "isThirdPartyTrackingResource": false,
[task 2020-07-08T10:33:59.933Z] 10:33:59     INFO -   "referrerPolicy": "no-referrer-when-downgrade",
[task 2020-07-08T10:33:59.934Z] 10:33:59     INFO -   "channelId": 265845590720515
[task 2020-07-08T10:33:59.934Z] 10:33:59     INFO - }, expected {
[task 2020-07-08T10:33:59.935Z] 10:33:59     INFO -   "type": "networkEvent",
[task 2020-07-08T10:33:59.935Z] 10:33:59     INFO -   "timeStamp": 1572867483805,
[task 2020-07-08T10:33:59.936Z] 10:33:59     INFO -   "node": null,
[task 2020-07-08T10:33:59.936Z] 10:33:59     INFO -   "actor": "server0.conn0.netEvent4",
[task 2020-07-08T10:33:59.936Z] 10:33:59     INFO -   "discardRequestBody": true,
[task 2020-07-08T10:33:59.937Z] 10:33:59     INFO -   "discardResponseBody": true,
[task 2020-07-08T10:33:59.937Z] 10:33:59     INFO -   "startedDateTime": "2019-11-04T11:06:34.542Z",
[task 2020-07-08T10:33:59.938Z] 10:33:59     INFO -   "request": {
[task 2020-07-08T10:33:59.938Z] 10:33:59     INFO -     "url": "http://example.com/inexistent.html",
[task 2020-07-08T10:33:59.938Z] 10:33:59     INFO -     "method": "GET",
[task 2020-07-08T10:33:59.939Z] 10:33:59     INFO -     "headersSize": 396
[task 2020-07-08T10:33:59.939Z] 10:33:59     INFO -   },
[task 2020-07-08T10:33:59.940Z] 10:33:59     INFO -   "isXHR": false,
[task 2020-07-08T10:33:59.940Z] 10:33:59     INFO -   "cause": {
[task 2020-07-08T10:33:59.941Z] 10:33:59     INFO -     "type": "img",
[task 2020-07-08T10:33:59.941Z] 10:33:59     INFO -     "loadingDocumentUri": "http://example.com/browser/devtools/client/webconsole/test/browser/stub-generators/test-network-event.html",
[task 2020-07-08T10:33:59.941Z] 10:33:59     INFO -     "lastFrame": {
[task 2020-07-08T10:33:59.953Z] 10:33:59     INFO -       "filename": "http://example.com/browser/devtools/client/webconsole/test/browser/stub-generators/test-network-event.html",
[task 2020-07-08T10:33:59.953Z] 10:33:59     INFO -       "lineNumber": 3,
[task 2020-07-08T10:33:59.954Z] 10:33:59     INFO -       "columnNumber": 1,
[task 2020-07-08T10:33:59.954Z] 10:33:59     INFO -       "functionName": "triggerPacket",
[task 2020-07-08T10:33:59.955Z] 10:33:59     INFO -       "asyncCause": null
[task 2020-07-08T10:33:59.955Z] 10:33:59     INFO -     },
[task 2020-07-08T10:33:59.956Z] 10:33:59     INFO -     "stacktraceAvailable": true
[task 2020-07-08T10:33:59.956Z] 10:33:59     INFO -   },
[task 2020-07-08T10:33:59.957Z] 10:33:59     INFO -   "response": {
[task 2020-07-08T10:33:59.957Z] 10:33:59     INFO -     "httpVersion": "HTTP/1.1",
[task 2020-07-08T10:33:59.958Z] 10:33:59     INFO -     "status": "404",
[task 2020-07-08T10:33:59.958Z] 10:33:59     INFO -     "statusText": "Not Found",
[task 2020-07-08T10:33:59.973Z] 10:33:59     INFO -     "headersSize": 160,
[task 2020-07-08T10:33:59.982Z] 10:33:59     INFO -     "remoteAddress": "127.0.0.1",
[task 2020-07-08T10:33:59.982Z] 10:33:59     INFO -     "remotePort": 8888,
[task 2020-07-08T10:33:59.983Z] 10:33:59     INFO -     "waitingTime": 2,
[task 2020-07-08T10:33:59.983Z] 10:33:59     INFO -     "content": {
[task 2020-07-08T10:33:59.984Z] 10:33:59     INFO -       "mimeType": "text/html; charset=utf-8"
[task 2020-07-08T10:33:59.984Z] 10:33:59     INFO -     },
[task 2020-07-08T10:33:59.985Z] 10:33:59     INFO -     "bodySize": 418,
[task 2020-07-08T10:33:59.985Z] 10:33:59     INFO -     "transferredSize": 578
[task 2020-07-08T10:33:59.985Z] 10:33:59     INFO -   },
[task 2020-07-08T10:33:59.986Z] 10:33:59     INFO -   "timings": {},
[task 2020-07-08T10:33:59.986Z] 10:33:59     INFO -   "updates": [
[task 2020-07-08T10:33:59.986Z] 10:33:59     INFO -     "eventTimings",
[task 2020-07-08T10:33:59.986Z] 10:33:59     INFO -     "requestCookies",
[task 2020-07-08T10:33:59.987Z] 10:33:59     INFO -     "requestHeaders",
[task 2020-07-08T10:33:59.987Z] 10:33:59     INFO -     "responseContent",
[task 2020-07-08T10:33:59.987Z] 10:33:59     INFO -     "responseCookies",
[task 2020-07-08T10:33:59.987Z] 10:33:59     INFO -     "responseHeaders",
[task 2020-07-08T10:33:59.988Z] 10:33:59     INFO -     "responseStart",
[task 2020-07-08T10:33:59.988Z] 10:33:59     INFO -     "securityInfo"
[task 2020-07-08T10:33:59.988Z] 10:33:59     INFO -   ],
[task 2020-07-08T10:33:59.988Z] 10:33:59     INFO -   "private": false,
[task 2020-07-08T10:33:59.989Z] 10:33:59     INFO -   "isThirdPartyTrackingResource": false,
[task 2020-07-08T10:33:59.989Z] 10:33:59     INFO -   "referrerPolicy": "no-referrer-when-downgrade",
[task 2020-07-08T10:33:59.989Z] 10:33:59     INFO -   "channelId": 265845590720515
[task 2020-07-08T10:33:59.989Z] 10:33:59     INFO - }
[task 2020-07-08T10:33:59.990Z] 10:33:59     INFO - Stack trace:
[task 2020-07-08T10:33:59.990Z] 10:33:59     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-07-08T10:33:59.990Z] 10:33:59     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_stubs_network_event.js:null:53
[task 2020-07-08T10:33:59.990Z] 10:33:59     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-07-08T10:33:59.990Z] 10:33:59     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-07-08T10:33:59.991Z] 10:33:59     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-07-08T10:33:59.991Z] 10:33:59     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1029
[task 2020-07-08T10:33:59.992Z] 10:33:59     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-07-08T10:33:59.992Z] 10:33:59     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_stubs_network_event.js | "GET request update" packet has expected value - Got {
[task 2020-07-08T10:33:59.992Z] 10:33:59     INFO -   "networkInfo": {
[task 2020-07-08T10:33:59.992Z] 10:33:59     INFO -     "type": "networkEvent",
[task 2020-07-08T10:33:59.993Z] 10:33:59     INFO -     "actor": "server0.conn0.netEvent4",
[task 2020-07-08T10:33:59.993Z] 10:33:59     INFO -     "request": {
[task 2020-07-08T10:33:59.993Z] 10:33:59     INFO -       "url": "http://example.com/inexistent.html",
[task 2020-07-08T10:33:59.994Z] 10:33:59     INFO -       "method": "GET",
...
Flags: needinfo?(farooqbckk)
Flags: needinfo?(farooqbckk)
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc898602e159
Request mimeType should be sent on response start. r=Honza,bomsy,devtools-backward-compat-reviewers

https://hg.mozilla.org/mozilla-central/rev/fc898602e159

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
QA Whiteboard: [qa-80b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: