Closed Bug 1646035 Opened 4 months ago Closed 3 months ago

Warp: fix Uint32Array loads

Categories

(Core :: JavaScript Engine: JIT, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently always load a double in Warp, but this can cause bailouts when we then try to unbox to int32. On octane-pdfjs this results in a recompile loop. I have a patch to fix this in CacheIR and Warp; it improves our pdfjs score quite a lot.

As long as only int32 values are read, use an int32-only stub. If the Uint32
value doesn't fit in an int32 support loading doubles.

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53c140dfc6c7
Fix return type for Uint32Array loads in Warp. r=evilpie
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.