Closed Bug 1646075 Opened 6 years ago Closed 6 years ago

onExternalResponse isn't being called for all downloads in Fenix

Categories

(GeckoView :: General, defect)

Product:
GeckoView
Component:
General
Version:
79 Branch
Platform:
Unspecified
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: codrut.topliceanu, Unassigned)

Details

I understand that every time a download starts EngineObserver.onExternalResource() <from AC> is supposed to be called by GeckoEngineSession.onExternalResponse(). However this only happens when a download is started and the user is prompted for confirmation.

Steps to reproduce:

  1. open fenix and go to thinkbroadband.com/download
  2. select a file to donwnload
  3. user is prompted to confirm download and EngineObserver.onExternalResource() is called
  4. long press any image (from any site) and select save to download said small image

Expected result:

  • EngineObserver.onExternalResource() is called for both downloads

Actual result:

  • EngineObserver.onExternalResource() is called only for downloads that require confirmation from the user

This is the correct behavior. onExternalResponse() (or onExternalResource() as it's called in a-c) is only called when there is an in-page navigation that results in a download (e.g. clicking a link). The download that results from "long press -> save" is initiated by the browser itself, so GeckoView isn't involved at all.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.