16461 - [dogfood] mousing over checkboxes in prefs reflows window

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

launch apprunner with paint flashing on.
open prefs window.
mouse over any checkbox, see the whole panel reflow/repaint.

Comment 1

[Mike Pinkerton (not reading bugmail)]

accepting

Comment 2

[leger]

Putting on [PDT-] radar.  At least it works on reflow. Not a dogfood blocker.
Please send bug to [e-mail] if you do not agree.

Comment 3

[Mike Pinkerton (not reading bugmail)]

reassigning to brendan since i'm going on vacation.

Comment 4

[Brendan Eich [:brendan]]

Bulk-reassigning pink's "paint" bugs.

/be

Comment 5

[rickg]

Kevin -- here are some paint bugs. We'll load balance after Wednesday's meeting

Comment 6

[Kevin McCluskey (gone)]

The problem is the checkbox in global.css changes the border width to 1px (the
default in html.css is a 2pixel border), but does not change the hover style
rule to match. The CSS style system sees that the border has changed width,
assumes the size of the frame has changed and causes a reflow.

If we want to keep the one pixel border for the checkbox we need to add the
following rules to mozilla\xpfe\global\resources\skin\global.css

window html|input[type=checkbox]:hover {
  border: 1px solid black;
}

window html|input[type=checkbox][disabled] {
  border: 1px solid;
}

window html|input[type=checkbox][disabled]:hover {
  border: 1px solid rgb(153, 153, 153);
}

window html|input[type=checkbox]:focus {
  border:1px dotted rgb(153, 153, 153);
}

Adding hyatt to CC line since he owns global.css

Comment 7

[Kevin McCluskey (gone)]

Fixed in Nov 11, 1999 3:22PM build.

Comment 8

[Claudius Gayle]

Pink, could you verify this fix (and others like it), since I don't have
debug build with which to verify these fixes?

Comment 9

[Mike Pinkerton (not reading bugmail)]

tested, this works muuuuuch better now.

Comment 10

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/981835518e0e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16461 - Ensure the proper items order after exiting Multiselect (https://github.com/mozilla-mobile/fenix/pull/16482)