1646154 - sentence with donation link on initial start screen shouldn't make assumptions about sentence structure and end

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://searchfox.org/comm-central/source/mailnews/base/content/msgAccountCentral.js#79-81

If you create a new profile or launch Thunderbird for the first time, the start page has a sentence encouraging to donate to Thunderbird. It makes the assumption the link can be at the end of the sentence and the sentence will end with a full stop.

This should be completely localizable.

Comment 1

[Andrei Hajdukewycz [:sancus]]

Looks like this is referring to the Account Central page, not the start page, so not my wheelhouse.

I assume there is some technical limitation here that caused it to be done this way, because appending a link to text this way is definitely wrong in terms of localizability.

Maybe :aleca knows.

Comment 2

[Magnus Melin [:mkmelin]]

Lasana, can you take this. I think I mentioned this issue on the other bug too.

(No reason, just a bug.)

Comment 3

[Lasana Murray]

Attachment: bug1646154a.patch

How is this? Does not seem to cause any issues if I place the link in the fluent file.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9158617 [details] [diff] [review]
bug1646154a.patch

Review of attachment 9158617 [details] [diff] [review]:
-----------------------------------------------------------------

This seems to have bitrotted.

::: mail/locales/en-US/messenger/accountCentral.ftl
@@ +51,5 @@
>      .aria-label = Import data from other programs
>  
>  about-paragraph = Thunderbird is the leading open source, cross-platform email and calendaring client, free for business and personal use. We want it to stay secure and become even better. A donation will allow us to hire developers, pay for infrastructure, and continue to improve.
>  
> +about-paragraph-2 = <b>Thunderbird is funded by users like you! If you like Thunderbird, please consider making a donation.</b> The best way for you to ensure Thunderbird remains available is to <a data-l10n-name="donation-link"> make a donation</a>.

Since you're changing the localization "value", you need to update the "key" as well. Otherwise localizers can't keep up. Something like 

about-paragraph-consider-donation, instead of about-paragraph-2

Comment 5

[Lasana Murray]

Attachment: bug1646154b.patch

Fixed

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9158876 [details] [diff] [review]
bug1646154b.patch

Review of attachment 9158876 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/06d12bae8e0d
Include donation link in accountCentral.ftl instead of doing it manually. r=mkmelin