Open Bug 1646289 Opened 1 year ago Updated 7 days ago

Replace uuid from TabTarget.id with unique window identifiers as used by WebDriver

Categories

(Remote Protocol :: CDP, task, P3)

task
Points:
2

Tracking

(Fission Milestone:Future)

Fission Milestone Future

People

(Reporter: whimboo, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [bidi-m2-mvp])

Attachments

(1 file)

With bug 1580766 fixed there is now a stable BrowsingContext.browserId identifier available which never changes in case of process changes. It's uniqueness allows us to get rid of the uuid and to make use of the id instead.

Note that it is also available via linkedBrowser.browserId.

The Target.id is a string, so when implementing the above changes we have to convert the id to a string when returning the value, and vice versa when receiving a command.

Assignee: nobody → gl
Status: NEW → ASSIGNED
Fission Milestone: --- → M6c

Gabriel, could you please finalize the patch to close this bug?

Flags: needinfo?(gl)

Someone from our team will have to finish it eventually.

Assignee: gl → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(gl)
Fission Milestone: M6c → M7
Whiteboard: dt-fission-future

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

Fission Milestone: M7 → ---

dt-fission-future don't need to block Fission MVP.

Fission Milestone: --- → Future
Depends on: 1680479
Component: CDP: Target → CDP
Depends on: 1693993

Actually to be in sync with WebDriver we will have to keep our own cache of uuids around that are based on the permanentKey for each browser.

Summary: Replace uuid from TabTarget.id with BrowsingContext.browserId → Replace uuid from TabTarget.id with unique window identifiers as used by WebDriver
Whiteboard: dt-fission-future → [bidi-m1-mvp]
Points: --- → 2
Duplicate of this bug: 1691494
Depends on: 1691501
Whiteboard: [bidi-m1-mvp] → [bidi-m2-mvp]
Priority: P3 → --

It's not clear atm if Puppeteer will get started with quarter with BiDi. As such moving to the reserved list for now.

Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.