164647 - Delete in context menu doesn't do anything for text

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[sujay]

using 8/23 branch build

1) launch netscape
2) launch composer
3) insert text: "HelloWorld"
4) insert caret between Hello and World
5) bring up right context menu
6) select "Delete"

nothing happens. User might expect the Delete menu option
to behave the same as the Delete key on the keyboard.

Comment 1

[Charles Manske]

weird. It fires the "cmd_delete". Note that "Delete" in the top-level Edit menu
is disabled if there is no selection, so I think we are handling the Del char
in the editor side-stepping the delete command (which only deletes a selection.)
I think we should simply remove "Delete", "Copy", and "Cut" if there's no 
selection?

Comment 2

[Charles Manske]

Attachment: patch v1

must use 'observes', not 'oncommand' so menuitems are disabled correctly.
(In context menus, disabled items are also hidden)

Comment 3

[Kathleen :Brade]

Comment on attachment 96770 [details] [diff] [review]
patch v1

r=brade

Comment 4

[Joe Hewitt (gone)]

Comment on attachment 96770 [details] [diff] [review]
patch v1

sr=hewitt

Comment 5

[Charles Manske]

checked into 1.2 trunk