1646832 - Don't submit Sentry issues for build team members

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement, P3)

Description

[Mitchell Hentges [:mhentges] 🦀]

As mentioned here, to reduce noise in reported Sentry errors, we should have a blocklist (starting with Ricky and I) to avoid submitting locally-caused errors.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

We can get the current user's email address by doing:

# Git
1. git config user.email | "[e-mail]"
# hg
1. hg config ui.username | "Mitchell Hentges <[e-mail]>"
2. Parse email from between "<...>", if possible

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1646832: Don't report Sentry issues for build team members r?rstewart

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1646832: Use objects to represent availability of Sentry r?rstewart

Sentry is initialized globally, but it's not clear to consumers when this actually happens.
For example, an unwary developer may call report_exception() within check_and_get_mach(),
not knowing that Sentry hasn't been initialized yet.

Using a class should make the dependency on register_sentry() more verbose.

Depends on D80913

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09f0deb1bebc
Don't report Sentry issues for build team members r=rstewart
https://hg.mozilla.org/integration/autoland/rev/81ad300530b8
Use objects to represent availability of Sentry r=rstewart

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/09f0deb1bebc
https://hg.mozilla.org/mozilla-central/rev/81ad300530b8

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1646832: Fix Sentry blocklist not applying to some members r?rstewart

Depends on D81792

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ecad36269be
Fix Sentry blocklist not applying to some members r=rstewart

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5ecad36269be

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1646832: Use NoopErrorReporter for build team members r?rstewart

register_sentry() should always return an error-reporter implementation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fad18d87c94
Use NoopErrorReporter for build team members r=rstewart

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8fad18d87c94