1646837 - Crash in [@ nsAbLDIFService::AddLdifRowToDatabase]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

This bug is for crash report bp-39854da4-4463-4b19-a2e8-5cabf0200618.

Top 10 frames of crashing thread:

0 xul.dll nsAbLDIFService::AddLdifRowToDatabase comm/mailnews/addrbook/src/nsAbLDIFService.cpp:386
1 xul.dll nsAbLDIFService::ImportLDIFFile comm/mailnews/addrbook/src/nsAbLDIFService.cpp:130
2 xul.dll ImportAddressImpl::ImportAddressBook comm/mailnews/import/text/src/nsTextImport.cpp:408
3 xul.dll nsImportGenericAddressBooks::BeginImport comm/mailnews/import/src/nsImportAddressBooks.cpp:437
4 xul.dll XPTC__InvokebyIndex 
5  @0x22563e99a3f 
6 xul.dll truncf 
7 xul.dll truncf 
8 xul.dll static XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1140
9 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:946

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1646837_abldifservice_crash.patch

Looks like outlist was null

Comment 2

[Ben Campbell]

Comment on attachment 9157770 [details] [diff] [review]
bug1646837_abldifservice_crash.patch

Review of attachment 9157770 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like it'll stop it crashing, so r+.
But, isn't it confusing to the user that the import looks like it's worked, but does nothing?
I get that this is probably a pretty niche issue, but it'd be nice to flag it up with a note or something.
So if anyone does any future work in this code it'll occur to them to propagate the error back out to the importLDIFFile() caller.

Comment 3

[Magnus Melin [:mkmelin]]

Yeah ideally this wouldn't be a void method... many of the error cases are unlikely though, so it's unclear if you're already not in bigger problems.

Comment 4

[Ben Campbell]

(In reply to Magnus Melin [:mkmelin] from comment #3)

Yeah ideally this wouldn't be a void method... many of the error cases are unlikely though, so it's unclear if you're already not in bigger problems.

That's what I figured. One to punt onward for the next time someone's wading about in this code :-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9a572242446d
fix Crash in [@ nsAbLDIFService::AddLdifRowToDatabase]. r=benc

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9157770 [details] [diff] [review]
bug1646837_abldifservice_crash.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9157770 [details] [diff] [review]
bug1646837_abldifservice_crash.patch

Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f001e566656e