Closed Bug 1646840 Opened 3 months ago Closed 3 months ago

mach vendor rust on Windows uses CRLF line endings in .cargo/config.in

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: agashlin, Assigned: rstewart)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Running ./mach vendor rust on Windows writes .cargo/config.in with CRLF line endings. I think can be fixed by explicitly specifying the newline char as in bug 1619788, or maybe just open "wb"?

Ricky, are you interested in taking this on?

Flags: needinfo?(rstewart)
Flags: needinfo?(rstewart)
Assignee: nobody → rstewart
Status: NEW → ASSIGNED
Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a7256e564b0
Ensure `mach vendor rust` writes out .cargo/config.in with LF newlines on Windows r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

Thanks, Ricky!

You need to log in before you can comment on or make changes to this bug.