1646878 - Ship stylesheets for browser_style

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Browser actions and the other actions have an option to load a browser stylesheet so that the UI looks more similar to the application UI. We've never shipped these stylesheets or made the option work, but we should. Also at least one of them is used in the add-on manager preferences.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1646878-browser-style-1.diff

I picked up a few minor updates to ExtensionPopups.jsm while I was there.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9157818 [details] [diff] [review]
1646878-browser-style-1.diff

Review of attachment 9157818 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29838b8b530f
Ship stylesheets for browser_style. r=mkmelin

Comment 4

[Magnus Melin [:mkmelin]]

I guess we should uplift?

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9157818 [details] [diff] [review]
1646878-browser-style-1.diff

(In reply to Magnus Melin [:mkmelin] from comment #4)
> I guess we should uplift?

Yeah, there's no harm. I'd push it into a point release anyway, so it might as well be point-0.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9157818 [details] [diff] [review]
1646878-browser-style-1.diff

Also no regressions filed since landing, so Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/d92be5204ca8