Closed Bug 1646893 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24246 - deduplicate and sort font-variation-settings when computing style.

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24246 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24246
Details from upstream follow.

George Steel <gtsteel@google.com> wrote:

deduplicate and sort font-variation-settings when computing style.

Make interpolation type always run CSSValues through the converter for
this property.

Update remaining WPT teststo use order-invariant comparison (as most
tests for this property already use).

spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def

If the same axis name appears more than once, the value associated with
the last appearance supersedes any previous value for that axis. This
deduplication is observable by accessing the computed value of this
property.

resolution https://github.com/w3c/csswg-drafts/issues/1959
RESOLVED: For both font-variation-settings and font-feature-settings,
the computed value is a map (and thus specified dupes are removed)

Bug: 1005355
Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
Reviewed-on: https://chromium-review.googlesource.com/2253248
WPT-Export-Revision: a24b961b83738d283e6fa0c2bafaafa2fd0f4ddb

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 405 subtests

Status Summary

Firefox

OK : 9
PASS: 1989[Gecko-windows7-32-debug, Gecko-windows7-32-opt] 2024[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub]
FAIL: 3[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] 13[Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 9
PASS: 1791
FAIL: 55

Safari

OK : 9
PASS: 381
FAIL: 351

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-fonts/parsing/font-variation-settings-computed.html
Property font-variation-settings value 'normal': FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
Property font-variation-settings value '"wght" 700, "wght" 500' duplicate values should be removed, keeping the rightmost occurrence.: FAIL (Chrome: FAIL, Safari: FAIL)
Property font-variation-settings value '"wght" 700, "XHGT" 0.7': FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
Property font-variation-settings value '"wght" 700': FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
Property font-variation-settings value '"AB@D" 0.5': FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
Property font-variation-settings value '"XHGT" calc(0.4 + 0.3)': FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
/web-animations/animation-model/animation-types/addition-per-property-001.html
font-variation-settings: ""wdth" 1, "wght" 1.1" onto ""wdth" 5": FAIL (Chrome: PASS, Safari: FAIL)
/web-animations/animation-model/animation-types/accumulation-per-property-001.html
font-variation-settings: ""wdth" 1, "wght" 1.1" onto ""wdth" 5": FAIL (Chrome: PASS, Safari: FAIL)
/css/css-fonts/parsing/font-variation-settings-valid.html
e.style['font-variation-settings'] = ""wght" 700" should set the property value: FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
e.style['font-variation-settings'] = "'wght' 1e3, 'slnt' -450.0e-1" should set the property value: FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
e.style['font-variation-settings'] = ""a cd" 0.5" should set the property value: FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
e.style['font-variation-settings'] = ""ab@d" 0.5" should set the property value: FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
e.style['font-variation-settings'] = "normal" should set the property value: FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
e.style['font-variation-settings'] = ""wght" 700, "XHGT" 0.7" should set the property value: FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
e.style['font-variation-settings'] = "'wght' 700" should set the property value: FAIL [Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f3f3e7ee8ce
[wpt PR 24246] - Deduplicate and sort font-variation-settings when computing style., a=testonly
https://hg.mozilla.org/integration/autoland/rev/64012c09cbd9
[wpt PR 24246] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6f3f3e7ee8ce
https://hg.mozilla.org/mozilla-central/rev/64012c09cbd9

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.