1646928 - Bogus URL autocorrect for servers starting with 'ps'

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[ghr]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

In the «awesomebar», type pserver:8080 or pserver.mydomain.com:8080

Actual results:

The URL autocorrection feature tries to load httpserver:8080, which obviously results in an error page.

Expected results:

Load the website which URL is http://pserver:8080 or http://pserver.mydomain.com:8080

Comment 1

[ghr]

Hello,

It's my first bug report, and honestly I never thought I would create even one in my life. I did not find this hunting for bugs, I just stumbled on a specific problem accessing the web interface of some print servers in a corporate environment, and trying to understand the issue, I noticed the autocorrect behavior.

Knowing that it's not critical, since manually prefixing with http:// (or even a simple '/') allows Firefox to load the correct page.

Thanks.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Marco Bonardo [:mak]]

The problem is here:
https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/docshell/base/URIFixup.jsm#324-329

we fixup ps to https, we should require a colon after it though.

Comment 4

[ghr]

Thanks for spotting this 👍👍

As a consequence, I learnt about browser.fixup.typo.scheme (does not exist by default, like browser.fixup.dns_first_for_single_words which is also very useful in corporate environments). So I created it, set it to false, and now Firefox stopped trying to mess up my server names ...

Thank you again.

Comment 5

[Marco Bonardo [:mak]]

disabling scheme typo fixes will have other consequences, so once this bug is fixed I'd suggest to revert the pref change.

Comment 6

[Marco Bonardo [:mak]]

Attachment: Bug 1646928 - Bogus scheme typo correction in URIFixup. r=harry

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178ce324531b
Bogus scheme typo correction in URIFixup. r=harry

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/178ce324531b

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 9159691 [details]
Bug 1646928 - Bogus scheme typo correction in URIFixup. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: Certain domains will be "transformed" unexpectedly, like pserver to httpserver.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. type pserver:8000 or pserver.com:8000 in the urlbar and confirm

2. check we don't try to load httpserver:8000

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch with an automated test
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is particularly concerning for enterprises since it also affects intranet domains
• User impact if declined: Certain domains will be "transformed" unexpectedly, like pserver to httpserver.
• Fix Landed on Version: 80
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch with an automated test
• String or UUID changes made by this patch:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9159691 [details]
Bug 1646928 - Bogus scheme typo correction in URIFixup. r=harry

Approved for 79.0b2. We'll revisit the ESR78 request later this cycle after this has baked a bit more.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/718e80f1f6da

Comment 12

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2020-06-19) on Windows 10x64.
I tested everything on latest Nightly 80.a1 and Firefox 79.0b2 using Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9159691 [details]
Bug 1646928 - Bogus scheme typo correction in URIFixup. r=harry

Thanks for the verification on Nightly and Beta. Approved for 78.1esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/c140acd62ff2

Comment 16

[Cristian Baica [:cbaica], Release Desktop QA]

Issue is verified fixed using the latest Fx91.3.0ESR version on Windows 10 and Ubuntu 20.04.