1646974 - Missing requests in Netmonitor

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[dansoper]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Open Netmonitor, then load this page:
http://adobkin.name/firefox/unstyled-flash-bug.html

Actual results:

2 requests are listed (the HTML page, and the favicon)

Expected results:

3 requests should be listed (a css/php file)

I came across this problem while debugging something else. The similarity between my situation and the above page is that the css file is getting added using document.write.

The problem is in Firefox Nightly, and 78. It is not in 77.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting!
I can reproduce.

Looks like this regressed.

Comment 3

[Alexandru Trif, Desktop QA [:atrif]]

Hello! Reproduced the issue using Firefox 79.0a1 (20200621093846) and 78.0b9 (20200619002543) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. Firefox 77.0.1 (20200602222727) is not affected.
I ran a regression range on Windows 10x64 and mozregression pointed to:
Found commit message: Bug 1633850: Use the loading policy to restrict networks of StyleEditor. r=Honza

Daisuke Akatsuka can you please have a look? Thank you!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much for reporting!
Yeah, I could reproduce. I will take a look at this.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1646974: Introduce and use isInDevToolsContext flag.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1646974: Add a test for the stylesheet which is loaded as internal.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31930f9ca481
Introduce and use isInDevToolsContext flag. r=Honza,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/b440bc12d58e
Add a test for the stylesheet which is loaded as internal. r=Honza

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/31930f9ca481
https://hg.mozilla.org/mozilla-central/rev/b440bc12d58e

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9158464 [details]
Bug 1646974: Introduce and use isInDevToolsContext flag.

Beta/Release Uplift Approval Request

• User impact if declined: We might make users misunderstand networking requests since requests of stylesheets might be missed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We introduced a flag to our platform, but it is only for the DevTools purpose.
• String changes made/needed:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9158464 [details]
Bug 1646974: Introduce and use isInDevToolsContext flag.

Approved for 79.0b3.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5304973b102a
https://hg.mozilla.org/releases/mozilla-beta/rev/30db13a0b501

Comment 13

[Cristian Fogel [:cfogel]]

Confirmed with 79.0b2 on Windows 10.
Verified with 80.0a1 (2020-07-02) and 79.0b3 on Windows 10, macOS 10.15.5, Ubuntu 18.