Closed Bug 1646995 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 24255 - Don't navigate to jsurls with pending form submission

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24255 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24255
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Don't navigate to jsurls with pending form submission

In the case where a javascript: url is executed and submits a form
inside the execution and also returns a value, the form submission
should take precedence over the javascript: url's return value.

Although I could have made HasProvisionalNavigation return true instead
of adding a separate check for pending form submissions, I'm afraid to
do this because I don't know how it will affect the other places that
use HasProvisionalNavigation. I already have a bug open to track this,
and I will give it a shot after things with form submission settle down
more.

Bug: 1087431
Change-Id: If2761952b9a03f4193efb822ecf3db4fabc10f40

Reviewed-on: https://chromium-review.googlesource.com/2248485
WPT-Export-Revision: 9fbc386522dfb63022c0628e49cd6493eb7e5cbf

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ab79ee5b191
[wpt PR 24255] - Don't navigate to jsurls with pending form submission, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.