1646996 - Intermittent Assertion failure: !mDocuments.IsEmpty(), at /builds/worker/checkouts/gecko/dom/base/DocGroup.cpp:301

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=306918332&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eZwoathuSKOfoEeNfttrdg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-06-19T18:10:15.696Z] 18:10:15 INFO - GECKO(6388) | [Child 8504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (000001D144C6BC00) [pid = 8504] [serial = 25] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.697Z] 18:10:15 INFO - GECKO(6388) | [Child 8504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (000001D13DFACC00) [pid = 8504] [serial = 22] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.697Z] 18:10:15 INFO - GECKO(6388) | [Child 8504: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (000001D144C65400) [pid = 8504] [serial = 28] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.702Z] 18:10:15 INFO - GECKO(6388) | [Child 8504: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 000001D144C5F800 == 0 [pid = 8504] [id = {6ef504c8-c52e-4fa1-b456-1d3970eed78a}] [url = http://example.com/]
[task 2020-06-19T18:10:15.702Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0000026997180000) [pid = 7380] [serial = 53] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.702Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0000026999060400) [pid = 7380] [serial = 49] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.703Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (000002699905B000) [pid = 7380] [serial = 47] [outer = 0000000000000000] [url = data:application/json,2]
[task 2020-06-19T18:10:15.703Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0000026997184400) [pid = 7380] [serial = 44] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.713Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 000002699717B800 == 1 [pid = 7380] [id = {2d9dbea9-5a16-4181-9791-3933ee486e7e}] [url = http://example.com/]
[task 2020-06-19T18:10:15.713Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0000026990891000 == 0 [pid = 7380] [id = {69957c74-0add-42ae-bd5f-556edd775a41}] [url = about:blank]
[task 2020-06-19T18:10:15.772Z] 18:10:15 INFO - GECKO(6388) | [Child 8788: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0000022B5E577000) [pid = 8788] [serial = 14] [outer = 0000000000000000] [url = http://example.com/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]
[task 2020-06-19T18:10:15.772Z] 18:10:15 INFO - GECKO(6388) | [Child 8788: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0000022B5DF37090) [pid = 8788] [serial = 12] [outer = 0000000000000000] [url = http://example.com/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]
[task 2020-06-19T18:10:15.772Z] 18:10:15 INFO - GECKO(6388) | Assertion failure: !mDocuments.IsEmpty(), at /builds/worker/checkouts/gecko/dom/base/DocGroup.cpp:301
[task 2020-06-19T18:10:15.803Z] 18:10:15 INFO - GECKO(6388) | [Child 7456: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (000001D5061A4400) [pid = 7456] [serial = 14] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.803Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0000026996C27600) [pid = 7380] [serial = 50] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.804Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0000026996CB7C00) [pid = 7380] [serial = 51] [outer = 0000000000000000] [url = about:blank]
[task 2020-06-19T18:10:15.854Z] 18:10:15 INFO - GECKO(6388) | [Child 1396: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0000028573CC2090) [pid = 1396] [serial = 1] [outer = 0000000000000000] [url = about:newtab]
[task 2020-06-19T18:10:15.854Z] 18:10:15 INFO - GECKO(6388) | [Child 1396: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0000028573C95400 == 0 [pid = 1396] [id = {2d589aa3-e9b1-4ae0-99a8-109b1ba1ed99}] [url = about:newtab]
[task 2020-06-19T18:10:15.855Z] 18:10:15 INFO - GECKO(6388) | [Child 1396: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0000028574172800) [pid = 1396] [serial = 3] [outer = 0000000000000000] [url = about:newtab]
[task 2020-06-19T18:10:15.893Z] 18:10:15 INFO - GECKO(6388) | [Child 7380: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0000026996C27F10) [pid = 7380] [serial = 52] [outer = 0000000000000000] [url = http://example.com/]
[task 2020-06-19T18:10:15.893Z] 18:10:15 INFO - GECKO(6388) | [Child 7456: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (000001D50D065000) [pid = 7456] [serial = 15] [outer = 0000000000000000] [url = http://example.com/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]
[task 2020-06-19T18:10:15.893Z] 18:10:15 INFO - GECKO(6388) | [Child 7456: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (000001D50D08B090) [pid = 7456] [serial = 13] [outer = 0000000000000000] [url = http://example.com/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]
[task 2020-06-19T18:10:15.912Z] 18:10:15 INFO - GECKO(6388) | [Child 10160: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 00000251F5523000 == 0 [pid = 10160] [id = {76687f44-a745-4c28-be43-3b562f4e63a8}] [url = data:application/json,["http://example.com/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"]]
[task 2020-06-19T18:10:15.941Z] 18:10:15 INFO - Initializing stack-fixing for the first stack frame, this may take a while...
[task 2020-06-19T18:10:28.747Z] 18:10:28 INFO - GECKO(6388) | #01: anonymous namespace'::LabellingEventTarget::Release() [dom/base/DocGroup.cpp:116] [task 2020-06-19T18:10:28.747Z] 18:10:28 INFO - GECKO(6388) | #02: TimerThread::PostTimerEvent(already_AddRefed<nsTimerImpl>) [xpcom/threads/TimerThread.cpp:738] [task 2020-06-19T18:10:28.747Z] 18:10:28 INFO - GECKO(6388) | #03: TimerThread::Run() [xpcom/threads/TimerThread.cpp:415] [task 2020-06-19T18:10:28.747Z] 18:10:28 INFO - GECKO(6388) | #04: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1236] [task 2020-06-19T18:10:28.747Z] 18:10:28 INFO - GECKO(6388) | #05: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:501] [task 2020-06-19T18:10:28.747Z] 18:10:28 INFO - GECKO(6388) | #06: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:303] [task 2020-06-19T18:10:28.747Z] 18:10:28 INFO - GECKO(6388) | #07: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:309] [task 2020-06-19T18:10:28.748Z] 18:10:28 INFO - GECKO(6388) | #08: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291] [task 2020-06-19T18:10:28.748Z] 18:10:28 INFO - GECKO(6388) | #09: static nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:449] [task 2020-06-19T18:10:28.990Z] 18:10:28 INFO - GECKO(6388) | #10: PR_NativeRunThread(void*) [nsprpub/pr/src/threads/combined/pruthr.c:408] [task 2020-06-19T18:10:28.990Z] 18:10:28 INFO - GECKO(6388) | #11: pr_root(void*) [nsprpub/pr/src/md/windows/w95thred.c:140] [task 2020-06-19T18:10:28.991Z] 18:10:28 INFO - fix-stacks error: failed to read breakpad symbols dirZ:\task_1592587930\build\symbols\ucrtbase.pdbforC:\Windows\System32\ucrtbase.dll[task 2020-06-19T18:10:28.991Z] 18:10:28 INFO - fix-stacks note: this is expected and harmless for system libraries on debug automation runs [task 2020-06-19T18:10:28.992Z] 18:10:28 INFO - GECKO(6388) | #12: o_ceil [C:\Windows\System32\ucrtbase.dll + 0x1c4be] [task 2020-06-19T18:10:28.992Z] 18:10:28 INFO - fix-stacks error: failed to read breakpad symbols dirZ:\task_1592587930\build\symbols\KERNEL32.DLLforC:\Windows\System32\KERNEL32.DLL`

Comment 1

[Intermittent Failures Robot]

1 failures in 4035 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1646996&startday=2020-06-15&endday=2020-06-21&tree=all

Comment 2

[Byron Campen [:bwc]]

There's no webrtc-related stuff in the test case from comment 1. Probably some other cause.

Comment 3

[Intermittent Failures Robot]

1 failures in 5252 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1646996&startday=2020-06-22&endday=2020-06-28&tree=all

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

This is still happening.

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311546025&repo=autoland&lineNumber=7903

Comment 6

[Intermittent Failures Robot]

1 failures in 4289 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1646996&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 7

[Intermittent Failures Robot]

1 failures in 4618 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1646996&startday=2020-08-03&endday=2020-08-09&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 3601 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1646996&startday=2020-08-10&endday=2020-08-16&tree=all

Comment 9

[Intermittent Failures Robot]

1 failures in 4100 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1646996&startday=2020-08-17&endday=2020-08-23&tree=all

Comment 10

[Jens Stutte [:jstutte]]

Might this be related to bug 1644009, in particular patch 11 ?

Comment 11

[Jean-Yves Avenard [:jya]]

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #10)

Might this be related to bug 1644009, in particular patch 11 ?

I can't see how this could be related to direct task dispatching; there's none dispatching nor being dispatched; what make you think it could be related?

Looks like we have a task posted via a timer, and that task calls LabellingEventTarget::EventTargetFor

This is Andreas called

Comment 12

[Andreas Farre [:farre]]

Yep, so this is akward. ~DocGroup calls EventTargetFor to get a target to proxy release the DocGroup on. EventTargetFor checks that !mDocuments.IsEmpty(), which it certainly is when destroying a DocGroup.

Comment 13

[Andreas Farre [:farre]]

Attachment: Bug 1646996 - Proxy to main thread in ~DocGroup. r=smaug

When destroying the DocGroup, it will most certainly have no documents
attached to it, which makes labelling them a strange thing to do. And
the event target in DocGroup would most certainly dispatch to release
on the main thread anyway, so switch to do that right away.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e9dde2d0236
Proxy to main thread in ~DocGroup. r=smaug

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7e9dde2d0236

Comment 16

[Intermittent Failures Robot]

1 failures in 4046 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1646996&startday=2020-08-24&endday=2020-08-30&tree=all

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Is there any possibly real-world impact to users here which would justify backport consideration or can this ride the 82 train to release?

Comment 18

[Andreas Farre [:farre]]

Nope, no real world impact. It's a debug assert that really didn't protect from something bad in this particular case.