Closed Bug 164707 Opened 18 years ago Closed 14 years ago

Provide a way to view/delete orphan certs

Categories

(Core Graveyard :: Security: UI, defect, P1)

Other Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: KaiE, Assigned: KaiE)

Details

(Whiteboard: [kerh-coa])

Attachments

(4 files, 2 obsolete files)

Provide a way to view/delete orphan certs

Mozilla should provide a way to have a look at the list of certs that
Mozilla/NSS is storing in the user's profile, but which are not classified as
any of the 4 categories user/other people/web sites/CA.

I'm not sure whether we want to enable a 5th tab "orphans" by default, but at
least it can be helpful for analysis, as bug 163900 shows.
Attached patch Patch v1 (obsolete) — Splinter Review
This little patch, completely cloned from other already existant code, provides
the feature.

However, the new tab is not enabled by default. You have to manually set a pref
in prefs.js:
  user_pref("security.certmanager.showorphans", true);

If you do not have that pref, the tab will not be visible.
Attached patch Patch v2 (obsolete) — Splinter Review
Attachment #96746 - Attachment is obsolete: true
I think we should take this patch.

Nelson, Sean, I have another suggestion for the additional "tab" of certificates
to add to cert manager.

What about naming the column "Miscellaneous"? And would it be fine to simply
call it "Misc"?
Keywords: nsbeta1
Either Miscellaneous or Misc. would be fine with me.  Sean?
For what it's worth, stability enhanced Linux, 
Mac OSX and Windows builds based on Mozilla 1.3.1, 
that also contain the patch
from this bug, are available at http://wamcom.org
Product: PSM → Core
Whiteboard: [kerh-coa]
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Attached patch Patch v3Splinter Review
The previous patch bitrotted, updated to current trunk.
Attachment #115343 - Attachment is obsolete: true
Attached image Screenshot
QA Contact: junruh
Comment on attachment 240967 [details]
Screenshot

Hi Mike.
We would like to add a fifth tab to certificate manager.
While the existing four tabs display certs of well known types, the user might own other certificates.

Are you ok with the idea to add this extra tab?

In the past the wording "extra" has been suggested. Do you like that? (Another option would be "unknown")

Do you like the descriptive phrase (underlined in red in the screenshot).

Thanks in advance for your comments.
Attachment #240967 - Flags: ui-review?(beltzner)
Comment on attachment 240967 [details]
Screenshot

This will do as a stop-gap solution, but I'll file a follow-up bug to track what I think the real changes to the certificate manager should be in the long-term.
Attachment #240967 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 240965 [details] [diff] [review]
Patch v3

Bob, can you please review the patch?
Attachment #240965 - Flags: review?
Attachment #240965 - Flags: review? → review?(rrelyea)
Comment on attachment 240965 [details] [diff] [review]
Patch v3

r+=relyea
Attachment #240965 - Flags: review?(rrelyea) → review+
fixed on trunk
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
deleteOrphanCertFlag=deleteOrphanFlag
deleteOrphanCertImpact=

I think you should add a localization note to these two properties, as it may not be clear to the localizers what to do with these... 
(In reply to comment #13)
> deleteOrphanCertFlag=deleteOrphanFlag
> deleteOrphanCertImpact=
> 
> I think you should add a localization note to these two properties, as it may
> not be clear to the localizers what to do with these... 


Thanks for making me aware.
Actually, the deleteOrphanFlag is no longer necessary since bug 348259. It should have been removed from that older patch.

I'm reopening and will attach a supplemental patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #248325 - Flags: review?(rrelyea)
Comment on attachment 248325 [details] [diff] [review]
Supplemental Patch v4

Bob, can you please review?

This patch removes the unnecessary strings from the bundle.

It fixes an issue with the delete function.

Before this patch, we defaulted to show all uncategorized certs in the server tab, which was incorrect. This patch will restored the UNKNOWN_CERT type when no other categorization is possible.
Attached file sample certdb
This is a sample cert db that can be used to QA this bug.
Extract this zip file to a new test profile directory.
With the patch applied, you'll get a cert in the Extra tab and you should be able to delete it.
Comment on attachment 248325 [details] [diff] [review]
Supplemental Patch v4

r=rrelyea
Attachment #248325 - Flags: review?(rrelyea) → review+
Supplemental patch checked in, marking fixed.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.