1647200 - Double schema to the pasteboard for non-standard domains

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Xu Siyuan]

Attachment: bugz.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Add ###.###.###.### some-name to hosts file, ensure there is a web server on it.
Access http://some-name/some/path
Click the address bar, instead of standard domains like example.com (which hides http://), it will explicitly add prefix http://
Select and copy the pahttp://some-name
Paste anywhere

Actual results:

http://http://some-name is pasted

Expected results:

http://some-name is pasted

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Hm, this may be due to us adding back the protocol for non-whitelisted hosts, I must check.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1647200 - Don't add the trimmed protocol on urlbar copy if it's already present. r=dao

When focusing the urlbar after a non-whitelisted host is visited, we add the
trimmed protocol in front of it, because otherwise modifying the url and then
resubmitting may end up searching. Due to that, it's possible the value is not
trimmed when we build the clipboard string.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/398c202ed56e
Don't add the trimmed protocol on urlbar copy if it's already present. r=dao

Comment 4

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=QIkrE61ORDOWgxLxqwpyfg.1&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s-2%2Cm-fis%28bc2%29&fromchange=398c202ed56e9258ccefbbefde19e112cf18712b

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=308097048&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/af990b74d334f3146888f4d2aa21a74017e6543d

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

it looks like linux64 fission only? Strange, I guess I'll have to check on Try.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The problem is apparently due to the fact we don't blur before focus so we don't get the focus event... I'm modernizing the test and checking on Try if the problem is solved.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b90c377a85a
Don't add the trimmed protocol on urlbar copy if it's already present. r=dao

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2b90c377a85a

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 9160080 [details]
Bug 1647200 - Don't add the trimmed protocol on urlbar copy if it's already present. r=dao

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This may actually be more interesting for enterprise than beta, because enterprise uses a lot more non-standard domains.
• User impact if declined: Copying a partial url containing an unknown domain (maybe intranet) may end up doubling the protocol in the copied string.
• Fix Landed on Version: 80
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is a very simple if condition and has a test
• String or UUID changes made by this patch:

Beta/Release Uplift Approval Request

• User impact if declined: Copying a partial url containing an unknown domain (maybe intranet) may end up doubling the protocol in the copied string.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
  Add a custom domain to /etc/hosts that resolves to an http page, ensure the urlbar contains "yourdomain/something" when you visit it. When the urlbar gets focused http:// should be added in front of the trimmed url. Copying the urlbar value at this point should copy the right url and not duplicate the http protocol.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is a very simple if condition and has a test
• String changes made/needed:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9160080 [details]
Bug 1647200 - Don't add the trimmed protocol on urlbar copy if it's already present. r=dao

Approved for 79.0b5 and 78.1esr. Thanks for including tests.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/9dfd39ee6c10

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ec4a10a0414

Comment 14

[Adrian Florinescu [:aflorinescu]]

Reproduced the issue on 78.0.2 2020-07-08, then procedeed to verify the fix with:

80.0a1 2020-07-14
79.0b7 2020-07-10

using:
Window 10
Mac 10.13.6
Ubuntu 20

Leaving reminder to re-check this on 78.1esr when it is near release to reduce any risk from other uplifts regression.

Comment 15

[Adrian Florinescu [:aflorinescu]]

Verified the fix with 78.1.0esr 2020-07-22 using Windows10 and Ubuntu20.